From: Jean Delvare <khali@linux-fr.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.4] I2C updates for 2.4.28 (5/5)
Date: Sat, 20 Nov 2004 13:42:03 +0100 [thread overview]
Message-ID: <20041120134203.0af28c59.khali@linux-fr.org> (raw)
In-Reply-To: <20041120125423.42527051.khali@linux-fr.org>
Original report and discussion:
http://archives.andrew.net.au/lm-sensors/msg28295.html
Bottom line:
Some debug messages in the i2c-core lack their trailing newline, which
breaks the logs.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
diff -ruN linux-2.4.28-rc2/drivers/i2c.orig/i2c-core.c linux-2.4.28-rc2/drivers/i2c/i2c-core.c
--- linux-2.4.28-rc2/drivers/i2c.orig/i2c-core.c 2004-11-09 22:02:16.000000000 +0100
+++ linux-2.4.28-rc2/drivers/i2c/i2c-core.c 2004-11-09 22:04:41.000000000 +0100
@@ -901,7 +901,7 @@
if (addr == address_data->normal_i2c[i]) {
found = 1;
DEB2(printk(KERN_DEBUG "i2c-core.o: found normal i2c entry for adapter %d, "
- "addr %02x", adap_id,addr));
+ "addr %02x\n", adap_id, addr));
}
}
diff -ruN linux-2.4.28-rc2/drivers/i2c.orig/i2c-proc.c linux-2.4.28-rc2/drivers/i2c/i2c-proc.c
--- linux-2.4.28-rc2/drivers/i2c.orig/i2c-proc.c 2004-11-09 22:02:09.000000000 +0100
+++ linux-2.4.28-rc2/drivers/i2c/i2c-proc.c 2004-11-09 22:03:59.000000000 +0100
@@ -762,7 +762,7 @@
#ifdef DEBUG
printk
(KERN_DEBUG "i2c-proc.o: found normal isa_range entry for adapter %d, "
- "addr %04x", adapter_id, addr);
+ "addr %04x\n", adapter_id, addr);
#endif
found = 1;
}
@@ -776,7 +776,7 @@
#ifdef DEBUG
printk
(KERN_DEBUG "i2c-proc.o: found normal i2c entry for adapter %d, "
- "addr %02x", adapter_id, addr);
+ "addr %02x\n", adapter_id, addr);
#endif
}
}
--
Jean Delvare
http://khali.linux-fr.org/
prev parent reply other threads:[~2004-11-20 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-20 11:54 I2C updates for 2.4.28 Jean Delvare
2004-11-20 12:07 ` [PATCH 2.4] I2C updates for 2.4.28 (1/5) Jean Delvare
2004-11-20 12:16 ` [PATCH 2.4] I2C updates for 2.4.28 (2/5) Jean Delvare
2004-11-20 12:26 ` [PATCH 2.4] I2C updates for 2.4.28 (3/5) Jean Delvare
2004-11-20 12:42 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041120134203.0af28c59.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox