public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: ambx1@neo.rr.com, perex@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] misc ISAPNP cleanups
Date: Sun, 21 Nov 2004 16:18:58 +0100	[thread overview]
Message-ID: <20041121151856.GM2829@stusta.de> (raw)
In-Reply-To: <20041116050316.GC29574@neo.rr.com>

On Tue, Nov 16, 2004 at 12:03:16AM -0500, Adam Belay wrote:
> On Sat, Nov 13, 2004 at 04:02:34AM +0100, Adrian Bunk wrote:
> > The patch below removes some completely unused code and makes some 
> > needlessly global code static in drivers/pnp/isapnp/core.c .
> > 
> > Please review whether this patch is correct or whether it conflicts with 
> > pending ISAPNP updates/usages.
> > 
> > 
> > diffstat output:
> >  drivers/pnp/isapnp/core.c |   47 ++++++++------------------------------
> >  include/linux/isapnp.h    |   20 ----------------
> >  2 files changed, 11 insertions(+), 56 deletions(-)
> > 
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> 
> I have to check that this doesn't break any obscure isapnp drivers.  Otherwise

Why are these "obscure isapnp drivers" not included in the kernel?

> it looks good.  Some of them, like "isapnp_alloc", look obvious.
> 
> Thanks,
> Adam

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2004-11-21 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-13  3:02 [2.6 patch] misc ISAPNP cleanups Adrian Bunk
2004-11-16  5:03 ` Adam Belay
2004-11-21 15:18   ` Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-01-19  4:40 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041121151856.GM2829@stusta.de \
    --to=bunk@stusta.de \
    --cc=ambx1@neo.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox