public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] cdrom.c: make several functions static (fwd)
Date: Mon, 22 Nov 2004 08:28:36 +0100	[thread overview]
Message-ID: <20041122072833.GK26240@suse.de> (raw)
In-Reply-To: <20041121235851.GG13254@stusta.de>

On Mon, Nov 22 2004, Adrian Bunk wrote:
> 
> The patch forwarded below still applies and compiles against 
> 2.6.10-rc2-mm2 (I've edited it for a trivial context adjustment).
> 
> Please apply or comment on it.
> 
> 
> ----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----
> 
> Date:	Sun, 31 Oct 2004 22:33:19 +0100
> From: Adrian Bunk <bunk@stusta.de>
> To: axboe@suse.de
> Cc: linux-kernel@vger.kernel.org
> Subject: [2.6 patch] cdrom.c: make several functions static
> 
> The patch below makes several functions in cdrom.c static.
> 
> This includes cdrom_is_mrw and cdrom_is_random_writable which were 
> EXPORT_SYMBOL'ed but weren't used anywhere outside of cdrom.h .

They used to, that's why they are non-static. The patch looks fine,
thanks.

-- 
Jens Axboe


      reply	other threads:[~2004-11-22  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-21 23:58 [2.6 patch] cdrom.c: make several functions static (fwd) Adrian Bunk
2004-11-22  7:28 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041122072833.GK26240@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox