Re: swsusp bigdiff [was Re: [PATCH] Software Suspend split to two stage V2.]

hugang
2004-11-22T10:49:58Z

On Mon, Nov 22, 2004 at 11:26:12AM +0100, Pavel Machek wrote:
> Hi!
>
> > > > Here is the patch relative to your big diff. It tested pass with my x86
> > > > pc, But the sysfs interface can't works, I using reboot system call.
> > >
> > > Without PREEMPT and HIGHMEM it worked okay on an idle system. When I
> > > started kernel compilation while trying to swsusp, it crashed on
> > > resume.
> >
> > Here is my big diff relative to your big diff. :), It works.
> >
> > - Not need continuous page for pagedir.
> > Swsusp using continuous page (pagedir), to save the new address, old
> > address and swap offset, but in current implemention, it using
> > continuous page as array, so if has so many pages to save, we have to
> > allocate many (>5) continuous pages, most it it will failed.
> >
> > I using a easy link struct to resolve it.
>
> Yes, I'd like to get rid of "too many continuous pages" problem
> before. Small problem is that it needs to update x86-64 too, but I
I have not x86-64, so I have no chance to do it.

> guess that's okay. I'd like that version to go in *before* that
> page-cache stuff (it actually fails a lot in wild).
Yes, I agree.

>
> Could you possibly put page-cache stuff into separate file? It would
> be even nicer to have it configurable (run-time or compile-time) so
> that if swsusp fails, I can tell people "try again with page-cache
> stuff turned off"...
> Pavel
I'll do that. :)

--
Hu Gang / Steve
Linux Registered User 204016
GPG Public Key: http://soulinfo.com/~hugang/hugang.asc