public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: rusty@rustcorp.com.au, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] MODULE_PARM_: remove the __deprecated
Date: Mon, 22 Nov 2004 16:56:19 +0100	[thread overview]
Message-ID: <20041122155619.GG19419@stusta.de> (raw)

Hi Rusty,

I know you will not like this patch, but I consider it important since 
the current beghavior is pretty annoying.

When making patches here and there, I'm touching many different places 
in the kernel. One of the advantages of the 2.6 build system is that 
warnings are very visible - and often a new compile warning indicates 
that something with the patch is wrong.

MODULE_PARM_ might be deprecated.
But there are still over 2000 places in the kernel where it's used.
I consider it _very_ annoying if after changing the kernel, the whole 
screen is swamped with warnings that MODULE_PARM_ is deprecated as it 
still happens in several subsystems. That's quite annoying if you want 
to check whether changing a common header file has any negative effects.

This is not generally against using __deprecated, but currently 
MODULE_PARM_ generates so many warnings that it's really no fun.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.10-rc2-mm3-modular/include/linux/module.h.old	2004-11-22 15:51:17.000000000 +0100
+++ linux-2.6.10-rc2-mm3-modular/include/linux/module.h	2004-11-22 15:53:29.000000000 +0100
@@ -559,7 +559,7 @@
 	void *addr;
 };
 
-static inline void __deprecated MODULE_PARM_(void) { }
+static inline void MODULE_PARM_(void) { }
 #ifdef MODULE
 /* DEPRECATED: Do not use. */
 #define MODULE_PARM(var,type)						    \


             reply	other threads:[~2004-11-22 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-22 15:56 Adrian Bunk [this message]
2004-11-22 20:18 ` [2.6 patch] MODULE_PARM_: remove the __deprecated Rusty Russell
2004-11-23  5:43 ` Lee Revell
2004-11-23 10:44   ` Jim Nelson
2004-11-23 20:03     ` Lee Revell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041122155619.GG19419@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox