[patch 4/4] char/snsc: reorder set_current_state() and add_wait_queue()

janitor
2004-11-20T02:55:22Z

Any comments would be, as always, appreciated.

-Nish

Description: Reorder add_wait_queue() and set_current_state() as a
signal could be lost in between the two functions.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

---

linux-2.6.10-rc2-bk4-max/drivers/char/snsc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/char/snsc.c~reorder-state-drivers_char_snsc drivers/char/snsc.c
--- linux-2.6.10-rc2-bk4/drivers/char/snsc.c~reorder-state-drivers_char_snsc 2004-11-20 00:29:55.000000000 +0100
+++ linux-2.6.10-rc2-bk4-max/drivers/char/snsc.c 2004-11-20 00:29:55.000000000 +0100
@@ -192,8 +192,8 @@ scdrv_read(struct file *file, char __use
}

len = CHUNKSIZE;
- add_wait_queue(&sd->sd_rq, &wait);
set_current_state(TASK_INTERRUPTIBLE);
+ add_wait_queue(&sd->sd_rq, &wait);
spin_unlock_irqrestore(&sd->sd_rlock, flags);

schedule_timeout(SCDRV_TIMEOUT);
@@ -288,8 +288,8 @@ scdrv_write(struct file *file, const cha
return -EAGAIN;
}

- add_wait_queue(&sd->sd_wq, &wait);
set_current_state(TASK_INTERRUPTIBLE);
+ add_wait_queue(&sd->sd_wq, &wait);
spin_unlock_irqrestore(&sd->sd_wlock, flags);

schedule_timeout(SCDRV_TIMEOUT);
_