From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support
Date: Mon, 22 Nov 2004 23:29:45 -0800 [thread overview]
Message-ID: <20041123072944.GA22786@kroah.com> (raw)
In-Reply-To: <52hdnh83jy.fsf@topspin.com>
On Mon, Nov 22, 2004 at 10:47:29PM -0800, Roland Dreier wrote:
> Greg> Yeah, but a name in each file is much nicer.
>
> Very little of the kernel seems to follow this rule right now.
I agree, but it's good to add this for new files.
> Greg> One comment, the file drivers/infiniband/core/cache.c has a
> Greg> license that is illegal due to the contents of the file.
> Greg> Please change the license of the file to GPL only.
>
> ?? Can you explain this? What makes that file special?
You are using a specific data structure that is only licensed to be used
in GPL code. By using it in code that has a non-GPL license (like the
dual license you have) you are violating the license of that code, and
open yourself up to lawsuits by the holder of that code.
There, can I be vague enough? :)
To be straightforward, either drop the RCU code completely, or change
the license of your code.
Hm, because of the fact that you are linking in GPL only code into this
code (because of the .h files you are using) how could you ever expect
to use a BSD-like license for this collected work?
Aren't licenses fun...
thanks,
greg k-h
next prev parent reply other threads:[~2004-11-23 7:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041122713.SDrx8l5Z4XR5FsjB@topspin.com>
2004-11-22 15:13 ` [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support Roland Dreier
2004-11-22 19:33 ` Sam Ravnborg
2004-11-22 21:28 ` Roland Dreier
2004-11-22 22:25 ` Greg KH
2004-11-22 22:40 ` [openib-general] Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA(Subnet " Fab Tillier
2004-11-22 23:34 ` [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet " Roland Dreier
2004-11-23 6:41 ` Greg KH
2004-11-23 6:47 ` Roland Dreier
2004-11-23 7:29 ` Greg KH [this message]
2004-11-23 17:52 ` [openib-general] " Johannes Erdfelt
2004-11-23 18:38 ` Greg KH
2004-11-23 18:56 ` Roland Dreier
2004-11-23 19:01 ` Greg KH
2004-11-23 19:13 ` Johannes Erdfelt
2004-11-23 19:30 ` linux-os
2004-11-23 19:42 ` Greg KH
2004-11-24 19:23 ` Roland Dreier
2004-11-24 19:29 ` Greg KH
2004-11-23 15:27 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041123072944.GA22786@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox