From: Pete Zaitcev <zaitcev@redhat.com>
To: greg@kroah.com
Cc: zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: ub: oops with preempt ("Sahara Workshop")
Date: Tue, 23 Nov 2004 10:02:47 -0800 [thread overview]
Message-ID: <20041123100247.2ea47e2d@lembas.zaitcev.lan> (raw)
I admit that the code should be locked properly instead, but the global plan
is to drop all P3 tagged printks anyway. So let it be guarded for the moment.
Signed-off-by: Pete Zaitcev <zaitcev@yahoo.com>
--- linux-2.6.10-rc2-bk8-ub/drivers/block/ub.c 2004-11-16 17:03:02.000000000 -0800
+++ linux-2.6.10-rc1-ub/drivers/block/ub.c 2004-11-07 19:01:03.000000000 -0800
@@ -1535,8 +1535,11 @@
ub_revalidate(sc);
/* This is pretty much a long term P3 */
- printk(KERN_INFO "%s: device %u capacity nsec %ld bsize %u\n",
- sc->name, sc->dev->devnum, sc->capacity.nsec, sc->capacity.bsize);
+ if (!atomic_read(&sc->poison)) { /* Cover sc->dev */
+ printk(KERN_INFO "%s: device %u capacity nsec %ld bsize %u\n",
+ sc->name, sc->dev->devnum,
+ sc->capacity.nsec, sc->capacity.bsize);
+ }
/* XXX Support sector size switching like in sr.c */
blk_queue_hardsect_size(disk->queue, sc->capacity.bsize);
next reply other threads:[~2004-11-23 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 18:02 Pete Zaitcev [this message]
2004-11-24 23:26 ` ub: oops with preempt ("Sahara Workshop") Greg KH
2004-11-27 21:38 ` ub: oops with preempt ("Sahara Workshop") [u] Martin Schlemmer [c]
2004-11-28 0:55 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041123100247.2ea47e2d@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox