public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Chandler <alan@chandlerfamily.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: ide-cd problem
Date: Tue, 23 Nov 2004 20:13:50 +0100	[thread overview]
Message-ID: <20041123191349.GM13174@suse.de> (raw)
In-Reply-To: <41A3829C.4060901@pobox.com>

On Tue, Nov 23 2004, Jeff Garzik wrote:
> Jens Axboe wrote:
> > 		/* packet command */
> >-		HWIF(drive)->OUTB(WIN_PACKETCMD, IDE_COMMAND_REG);
> >+		spin_lock_irqsave(&ide_lock, flags);
> >+		HWIF(drive)->OUTBSYNC(drive, WIN_PACKETCMD, IDE_COMMAND_REG);
> >+		ndelay(400);
> >+		spin_unlock_irqrestore(&ide_lock, flags);
> > 		return (*handler) (drive);
> 
> 
> FWIW this ndelay(400) is required by the spec, when you submit a command.

Yes, I know it isn't pulled out of thin air :)

-- 
Jens Axboe


      reply	other threads:[~2004-11-23 19:18 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-20 18:42 ide-cd problem Alan Chandler
2004-11-20 19:47 ` Jens Axboe
2004-11-21  0:53   ` Alan Chandler
2004-11-21  8:56     ` Jens Axboe
2004-11-21 10:25       ` Alan Chandler
2004-11-21 16:13         ` Alan Chandler
2004-11-22  7:52           ` Alan Chandler
2004-11-22  8:01             ` Jens Axboe
2004-11-22 10:30               ` Alan Chandler
2004-11-22 10:51                 ` Jens Axboe
2004-11-22 11:29                   ` Alan Chandler
2004-11-22 11:31                     ` Jens Axboe
2004-11-22 12:53                       ` Alan Chandler
2004-11-22 13:02                         ` Jens Axboe
2004-11-22 19:19                           ` Alan Chandler
2004-11-22 23:48                             ` Alan Chandler
2004-11-23  7:13                               ` Alan Chandler
2004-11-23 14:51                                 ` Jens Axboe
2004-11-23 21:49                                   ` Alan Chandler
2004-11-26 23:39                                     ` Alan Chandler
2004-11-29 17:29                                       ` Bill Davidsen
2004-11-30  8:59                                     ` Alan Chandler
2004-12-10 21:32                                       ` ide-cd problem revisited - more brainpower needed Alan Chandler
2004-12-10 23:14                                         ` Alan Cox
2004-12-12  0:17                                           ` Alan Chandler
2004-12-12 11:39                                             ` Alan Cox
2004-12-12 13:34                                               ` Alan Chandler
2004-12-14  0:20                                                 ` Alan Chandler
2004-12-16 15:56                                                   ` Bill Davidsen
2004-12-17 23:59                                                     ` Alan Chandler
2004-11-24 23:19                           ` ide-cd problem Alan Cox
2004-11-25 15:29                             ` Jens Axboe
2004-11-25 16:25                               ` Alan Cox
2004-11-25 18:12                                 ` Jens Axboe
2004-11-25 18:45                                   ` Alan Chandler
2004-11-23 18:34               ` Jeff Garzik
2004-11-23 19:13                 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041123191349.GM13174@suse.de \
    --to=axboe@suse.de \
    --cc=alan@chandlerfamily.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox