[2.6 PATCH] visor: Don't count outstanding URBs twice

Roger Luethi
2004-11-23T19:40:08Z

Guys, can you please CC me when discussing patches of mine? I don't read
LKML religiously, and my procmail filters are pretty dumb. Thanks. So
my previous patch fixed the oops, but the driver's still borked.

Incrementing the outstanding_urbs counter twice for the same URB can't
be good. No wonder Simon didn't get far syncing his Palm.

Signed-off-by: Roger Luethi <rl@hellgate.ch>

--- linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c.orig 2004-11-23 20:23:27.592097112 +0100
+++ linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c 2004-11-23 20:24:53.496037728 +0100
@@ -497,7 +497,6 @@ static int visor_write (struct usb_seria
dev_dbg(&port->dev, "write limit hit\n");
return 0;
}
- ++priv->outstanding_urbs;
spin_unlock_irqrestore(&priv->lock, flags);

buffer = kmalloc (count, GFP_ATOMIC);