From: Simon Fowler <simon@himi.org>
To: Roger Luethi <rl@hellgate.ch>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 PATCH] visor: Don't count outstanding URBs twice
Date: Wed, 24 Nov 2004 11:40:37 +1100 [thread overview]
Message-ID: <20041124004037.GA4954@himi.org> (raw)
In-Reply-To: <20041123203023.GA13663@k3.hellgate.ch>
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
On Tue, Nov 23, 2004 at 09:30:23PM +0100, Roger Luethi wrote:
> On Tue, 23 Nov 2004 11:45:58 -0800, Greg KH wrote:
> > Your email client is putting headers in the messages that say not to do
> > this. Please fix your client :)
>
> D'oh! Fixed (I think).
>
> > But I'm not seeing people actually hit the write limit, according to the
> > logs that people are posting.
>
> What I found is bound to cause exactly the kind of problem Simon
> described, so I didn't check any further. _But_ comparing his log and
> the code, I can't help but notice that the missing "write limit hit"
> is the only instance of a dev_dbg in this driver. Coincidence?
>
> Roger
>
Your extra patch has fixed the problem - I was able to do a full
sync with it.
Greg: your suggestion of backing visor.c out to an earlier working
version made all sorts of badness happen - I can get you the logs if
you want, but I assume since Roger's patches fix the problem you
don't care about it any more . . .
Thanks for the prompt fix!
Simon
--
PGP public key Id 0x144A991C, or http://himi.org/stuff/himi.asc
(crappy) Homepage: http://himi.org
doe #237 (see http://www.lemuria.org/DeCSS)
My DeCSS mirror: ftp://himi.org/pub/mirrors/css/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-11-24 0:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 15:49 [2.6 PATCH] visor: Always do generic_startup Roger Luethi
2004-11-19 17:44 ` Greg KH
2004-11-21 1:23 ` Simon Fowler
2004-11-21 4:08 ` Greg KH
2004-11-21 7:15 ` Simon Fowler
2004-11-22 18:54 ` Greg KH
2004-11-23 19:36 ` [2.6 PATCH] visor: Don't count outstanding URBs twice Roger Luethi
2004-11-23 19:45 ` Greg KH
2004-11-23 20:30 ` Roger Luethi
2004-11-24 0:40 ` Simon Fowler [this message]
2004-11-24 23:25 ` Greg KH
2004-11-25 16:16 ` [2.6 PATCH] visor: Make URB limit error more visible Roger Luethi
2004-11-25 18:06 ` Greg KH
2004-11-28 17:11 ` Alan Cox
2004-11-30 0:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124004037.GA4954@himi.org \
--to=simon@himi.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox