From: Adrian Bunk <bunk@stusta.de>
To: James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] SCSI 53c700.c: make NCR_700_intr static (fwd)
Date: Wed, 24 Nov 2004 19:46:49 +0100 [thread overview]
Message-ID: <20041124184649.GF19873@stusta.de> (raw)
The patch forwarded below still applies and compiles against
2.6.10-rc2-mm3.
Please apply or comment of it's incorrect.
----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----
Date: Mon, 15 Nov 2004 02:47:13 +0100
From: Adrian Bunk <bunk@stusta.de>
To: James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org
Subject: [2.6 patch] SCSI 53c700.c: make NCR_700_intr static
NCR_700_intr is EXPORT_SYMBOL'e but has no external users.
Is the patch below correct or is future external usage planned?
diffstat output:
drivers/scsi/53c700.c | 4 ++--
drivers/scsi/53c700.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.h.old 2004-11-13 16:05:17.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.h 2004-11-13 16:19:50.000000000 +0100
@@ -63,7 +63,6 @@
struct NCR_700_Host_Parameters *, struct device *,
unsigned long, u8);
int NCR_700_release(struct Scsi_Host *host);
-irqreturn_t NCR_700_intr(int, void *, struct pt_regs *);
enum NCR_700_Host_State {
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.c.old 2004-11-13 16:19:58.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.c 2004-11-13 16:22:42.000000000 +0100
@@ -167,6 +167,7 @@
#include "53c700_d.h"
+STATIC irqreturn_t NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs);
STATIC int NCR_700_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *));
STATIC int NCR_700_abort(struct scsi_cmnd * SCpnt);
STATIC int NCR_700_bus_reset(struct scsi_cmnd * SCpnt);
@@ -1486,7 +1487,7 @@
return 1;
}
-irqreturn_t
+STATIC irqreturn_t
NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs)
{
struct Scsi_Host *host = (struct Scsi_Host *)dev_id;
@@ -2148,7 +2149,6 @@
EXPORT_SYMBOL(NCR_700_detect);
EXPORT_SYMBOL(NCR_700_release);
-EXPORT_SYMBOL(NCR_700_intr);
static struct spi_function_template NCR_700_transport_functions = {
.set_period = NCR_700_set_period,
----- End forwarded message -----
reply other threads:[~2004-11-25 4:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124184649.GF19873@stusta.de \
--to=bunk@stusta.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox