public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andreas Schwab <schwab@suse.de>
Cc: Andi Kleen <ak@suse.de>,
	akpm@osdl.org, linux-kernel@vger.kernel.org, tridge@samba.org,
	uweigand@de.ibm.com
Subject: Re: [PATCH] Sync in core time granuality with filesystems
Date: Thu, 25 Nov 2004 11:53:09 +0100	[thread overview]
Message-ID: <20041125105309.GA28698@wotan.suse.de> (raw)
In-Reply-To: <jek6saiwqr.fsf@sykes.suse.de>

On Thu, Nov 25, 2004 at 01:43:40AM +0100, Andreas Schwab wrote:
> Andi Kleen <ak@suse.de> writes:
> 
> > diff -urpN -X ../KDIFX linux-2.6.10rc2/fs/jfs/namei.c linux-2.6.10rc2-time/fs/jfs/namei.c
> > --- linux-2.6.10rc2/fs/jfs/namei.c	2004-10-19 01:55:28.000000000 +0200
> > +++ linux-2.6.10rc2-time/fs/jfs/namei.c	2004-11-21 23:27:52.000000000 +0100
> > @@ -1233,7 +1233,7 @@ static int jfs_rename(struct inode *old_
> >  	old_ip->i_ctime = CURRENT_TIME;
> >  	mark_inode_dirty(old_ip);
> >  
> > -	new_dir->i_ctime = new_dir->i_mtime = CURRENT_TIME;
> > +	new_dir->i_ctime = new_dir->i_mtime = current_fs_time(new_dir->i_sb);
> >  	mark_inode_dirty(new_dir);
> >  
> >  	/* Build list of inodes modified by this transaction */
> > @@ -1245,7 +1245,7 @@ static int jfs_rename(struct inode *old_
> >  
> >  	if (old_dir != new_dir) {
> >  		iplist[ipcount++] = new_dir;
> > -		old_dir->i_ctime = old_dir->i_mtime = CURRENT_TIME;
> > +		old_dir->i_ctime = old_dir->i_mtime = CURRENT_TIME; 
> 
> Is this supposed to be CURRENT_TIME_SEC?

No, JFS supports nanosecond resolution. The first hunk could
stay at CURRENT_TIME, but it doesn't matter much (would be just
a small optimization) 

-Andi

      reply	other threads:[~2004-11-26 23:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-24 16:15 [PATCH] Sync in core time granuality with filesystems Andi Kleen
2004-11-25  0:43 ` Andreas Schwab
2004-11-25 10:53   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041125105309.GA28698@wotan.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    --cc=tridge@samba.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox