From: Daniel Ritz <daniel.ritz@gmx.ch>
To: Dmitry Torokhov <dtor_core@ameritech.net>, linux-kernel@vger.kernel.org
Cc: Greg KH <greg@kroah.com>
Subject: Re: [PATCH 2.6] touchkitusb: module_param to swap axes
Date: Thu, 25 Nov 2004 21:18:17 +0100 [thread overview]
Message-ID: <200411252118.17690.daniel.ritz@gmx.ch> (raw)
In-Reply-To: <200411250010.09049.dtor_core@ameritech.net>
On Thursday 25 November 2004 06:10, Dmitry Torokhov wrote:
> On Wednesday 24 November 2004 04:28 pm, Daniel Ritz wrote:
> > add a module parameter to swap the axes. many displays need this...
> >
> > --- 1.2/drivers/usb/input/touchkitusb.c 2004-09-18 10:07:25 +02:00
> > +++ edited/drivers/usb/input/touchkitusb.c 2004-11-24 18:57:59 +01:00
> > @@ -59,6 +59,10 @@
> > #define DRIVER_AUTHOR "Daniel Ritz <daniel.ritz@gmx.ch>"
> > #define DRIVER_DESC "eGalax TouchKit USB HID Touchscreen Driver"
> >
> > +static int swap_xy;
> > +module_param(swap_xy, bool, 0);
>
> It looks it can easily be exported to userspace to allow switching "on-fly"
> since it is checked for every packet. I think 0600 will do.
>
agreed. and when 0600 is ok, i guess 0644 is ok too.
Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
--- 1.2/drivers/usb/input/touchkitusb.c 2004-09-18 10:07:25 +02:00
+++ edited/drivers/usb/input/touchkitusb.c 2004-11-24 18:57:59 +01:00
@@ -59,6 +59,10 @@
#define DRIVER_AUTHOR "Daniel Ritz <daniel.ritz@gmx.ch>"
#define DRIVER_DESC "eGalax TouchKit USB HID Touchscreen Driver"
+static int swap_xy;
+module_param(swap_xy, bool, 0644);
+MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped.");
+
struct touchkit_usb {
unsigned char *data;
dma_addr_t data_dma;
@@ -80,6 +84,7 @@
{
struct touchkit_usb *touchkit = urb->context;
int retval;
+ int x, y;
switch (urb->status) {
case 0:
@@ -103,13 +108,19 @@
goto exit;
}
+ if (swap_xy) {
+ y = TOUCHKIT_GET_X(touchkit->data);
+ x = TOUCHKIT_GET_Y(touchkit->data);
+ } else {
+ x = TOUCHKIT_GET_X(touchkit->data);
+ y = TOUCHKIT_GET_Y(touchkit->data);
+ }
+
input_regs(&touchkit->input, regs);
input_report_key(&touchkit->input, BTN_TOUCH,
TOUCHKIT_GET_TOUCHED(touchkit->data));
- input_report_abs(&touchkit->input, ABS_X,
- TOUCHKIT_GET_X(touchkit->data));
- input_report_abs(&touchkit->input, ABS_Y,
- TOUCHKIT_GET_Y(touchkit->data));
+ input_report_abs(&touchkit->input, ABS_X, x);
+ input_report_abs(&touchkit->input, ABS_Y, y);
input_sync(&touchkit->input);
exit:
next prev parent reply other threads:[~2004-11-26 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 21:28 [PATCH 2.6] touchkitusb: module_param to swap axes Daniel Ritz
2004-11-25 5:10 ` Dmitry Torokhov
2004-11-25 20:18 ` Daniel Ritz [this message]
2004-11-29 19:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411252118.17690.daniel.ritz@gmx.ch \
--to=daniel.ritz@gmx.ch \
--cc=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox