Re: Suspend 2 merge: 10/51: Exports for suspend built as modules.

Pavel Machek
2004-11-26T23:53:39Z

Hi!

> > > The sys_ functions are exported because a while ago, people suggested I
> > > use /dev/console to output text that doesn't need to be logged, and I
> > > also use /dev/splash for the bootsplash support. These functions were
> >
> > Well, we don't do ascii-art on kernel boot and I do not see why we should do it
> > on suspend. Distributions will love bootsplash integration, but it should stay as a separate
> > patch.
>
> It's modular, so no problem there.

That *is* problem. mainline kernel is not expected to carry stuff like
that. We do not have bash as a kernel module. Not even gzip. And we
should not have ascii-art, too.

> > See swsusp1... it has percentage printing, and I think it should
> > be possible to make it look good enough.
>
> We can always make a tex_ mode_for_Pavel plugin :>

Yes, and then kill all the other plugins from mainline patches and
submit that. That would work. Ouch and that means no ugly hooks all
over the place in whatever goes into mainline.... and preferably no
plugin interface, too.

> > Why do you need sys_mkdir?
>
> The text mode plugin is using it to make /dev (if it doesn't exist) so
> it can try to mount devfs (if necessary) and open /dev/console to do the
> output. I'd love to just use vt_console_print, but those who know better
> then me said to use /dev/console...

Ugh, ouch. So if /dev/ is not there you just go and walk over user's
filesystem? Please, let's forget the asciiart.

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!