Re: Suspend 2 merge: 49/51: Checksumming

Pavel Machek
2004-11-27T03:53:00Z

Hi!

> > > A plugin for verifying the consistency of an image. Working with kdb, it
> > > can look up the locations of variations. There will always be some
> > > variations shown, simply because we're touching memory before we get
> > > here and as we check the image.
> >
> > Debugging code, can live as external patch pretty well.
>
> Doesn't most of the kernel have debugging code in it? Maybe not as much,
> but most of the kernel isn't doing the same thing. Remember we have the
> option of compiling it out. If it lives as a separate patch, we're just
> making more work for me (I have to maintain the debug version and then
> make some transformation on it to get the mainline version).

There's so much of debuging code that it is unreadable. When it is
separate file it is not so bad, but you'll have 1000 people going over
it "What is this", trying to keep it up-to-date with sparse
annotations etc...

Is not it possible to just debug suspend2 and then drop the debugging
code, not maintaining it any longer?

> By the way, I'm really appreciating your interaction over all these
> points. I was getting worried that I wasn't getting enough. I should say
> now, too, that I'm away all weekend, so you won't get replies tomorrow
> and the day after.

Well, I worry that now you'll be getting way too much
interaction... Anyway have a nice weekend,
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!