Re: Suspend 2 merge: 16/51: Disable cache reaping during suspend.

Pavel Machek
2004-11-27T05:09:29Z

Hi!
> I have to admit to being a little unsure as to why this is needed, but
> suspend's reliability is helped a lot by disabling cache reaping while
> suspending. Perhaps one of the mm guys will be able to enlighten me
> here. Might be SMP related.

It would be good to understand it. Rather than slowing common code... why
not down(&cache_chain_sem) in suspend2?
Pavel

> {
> struct list_head *walk;
>
> - if (down_trylock(&cache_chain_sem)) {
> + if ((unlikely(test_suspend_state(SUSPEND_RUNNING))) ||
> + (down_trylock(&cache_chain_sem)))
> + {
> /* Give up. Setup the next iteration. */
> schedule_delayed_work(&__get_cpu_var(reap_work), REAPTIMEOUT_CPUC + smp_processor_id());
> return;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms