Re: Suspend 2 merge: 21/51: Refrigerator upgrade.

Nigel Cunningham
2004-11-26T20:38:59Z

Hi.

On Fri, 2004-11-26 at 05:33, Pavel Machek wrote:
> Hi!
>
> > Included in this patch is a new try_to_freeze() macro Andrew M suggested
> > a while back. The refrigerator declarations are put in sched.h to save
> > extra includes of suspend.h.
>
> try_to_freeze looks nice. Could we get it in after 2.6.10 opens?

I'm hoping to get the whole thing in mm once all these replies are dealt
with. Does that sound unrealistic?

try_to_freeze() should certainly be possible, because it was Andrew's
idea to start with.

> > +++ 582-refrigerator-new/drivers/pnp/pnpbios/core.c 2004-11-24 17:58:33.769748640 +1100
> > @@ -179,6 +179,10 @@
> > * Poll every 2 seconds
> > */
> > msleep_interruptible(2000);
> > +
> > + if(current->flags & PF_FREEZE)
> > + refrigerator(PF_FREEZE);
> > +
> > if(signal_pending(current))
> > break;
> >
>
> Use new interface here?

Could do. Will change.

> > */
> > int fsync_super(struct super_block *sb)
> > {
> > + int ret;
> > +
> > + /* A safety net. During suspend, we might overwrite
> > + * memory containing filesystem info. We don't then
> > + * want to sync it to disk. */
> > + if (unlikely(test_suspend_state(SUSPEND_DISABLE_SYNCING)))
> > + return 0;
> > +
>
> If it is safety net, do BUG_ON().

Could get triggered by user pressing SysRq. (Or via a panic?). I don't
think the SysRq should result in a panic; nor should a panic result in a
recursive call to panic (although I'm wondering here, wasn't the call to
syncing in panic taken out?).

Regards,

Nigel
--
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

You see, at just the right time, when we were still powerless, Christ
died for the ungodly. -- Romans 5:6