Re: 2.6.10-rc2-bk7 - Badness in cfq_put_request at drivers/block/cfq-iosched.c:1402

Christopher S. Aker
2004-11-24T21:00:44Z

> Can you try this simple check to see if it triggers anything?
>
> ===== cfq-iosched.c 1.13 vs edited =====
> --- 1.13/drivers/block/cfq-iosched.c 2004-10-30 01:35:21 +02:00
> +++ edited/cfq-iosched.c 2004-11-24 14:40:13 +01:00
> @@ -1389,6 +1389,8 @@
> struct cfq_data *cfqd = q->elevator->elevator_data;
> struct cfq_rq *crq = RQ_DATA(rq);
>
> + WARN_ON(!spin_is_locked(q->queue_lock));
> +
> if (crq) {
> struct cfq_queue *cfqq = crq->cfq_queue;

I'd be happy to, but I won't have a free machine for a couple of days. I'll can
probably give it a shot during the weekend...

-Chris