From: Adrian Bunk <bunk@stusta.de>
To: tim@cyberelk.net, linux-parport@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/block/paride/ cleanups
Date: Mon, 29 Nov 2004 13:26:25 +0100 [thread overview]
Message-ID: <20041129122625.GF9722@stusta.de> (raw)
In-Reply-To: <20041125101220.GC29539@infradead.org>
The patch below does the following cleanups in each if the five changed
C files:
- #ifndef MODULE: remove unused setup function
- make a needlessly global struct static
After this cleanup, setup.h is completely unuse and therefore removed.
diffstat output:
drivers/block/paride/setup.h | 70 -----------------------------------
drivers/block/paride/pcd.c | 22 -----------
drivers/block/paride/pd.c | 23 -----------
drivers/block/paride/pf.c | 23 -----------
drivers/block/paride/pg.c | 21 ----------
drivers/block/paride/pt.c | 23 -----------
6 files changed, 5 insertions(+), 177 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm3-full/drivers/block/paride/pcd.c.old 2004-11-24 23:45:49.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/block/paride/pcd.c 2004-11-24 23:46:42.000000000 +0100
@@ -142,26 +142,6 @@
static spinlock_t pcd_lock;
-#ifndef MODULE
-
-#include "setup.h"
-
-static STT pcd_stt[6] = {
- {"drive0", 6, drive0},
- {"drive1", 6, drive1},
- {"drive2", 6, drive2},
- {"drive3", 6, drive3},
- {"disable", 1, &disable},
- {"nice", 1, &nice}
-};
-
-void pcd_setup(char *str, int *ints)
-{
- generic_setup(pcd_stt, 6, str);
-}
-
-#endif
-
MODULE_PARM(verbose, "i");
MODULE_PARM(major, "i");
MODULE_PARM(name, "s");
@@ -218,7 +198,7 @@
struct gendisk *disk;
};
-struct pcd_unit pcd[PCD_UNITS];
+static struct pcd_unit pcd[PCD_UNITS];
static char pcd_scratch[64];
static char pcd_buffer[2048]; /* raw block buffer */
--- linux-2.6.10-rc2-mm3-full/drivers/block/paride/pd.c.old 2004-11-24 23:46:42.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/block/paride/pd.c 2004-11-24 23:46:55.000000000 +0100
@@ -157,27 +157,6 @@
static spinlock_t pd_lock = SPIN_LOCK_UNLOCKED;
-#ifndef MODULE
-
-#include "setup.h"
-
-static STT pd_stt[7] = {
- {"drive0", 8, drive0},
- {"drive1", 8, drive1},
- {"drive2", 8, drive2},
- {"drive3", 8, drive3},
- {"disable", 1, &disable},
- {"cluster", 1, &cluster},
- {"nice", 1, &nice}
-};
-
-void pd_setup(char *str, int *ints)
-{
- generic_setup(pd_stt, 7, str);
-}
-
-#endif
-
MODULE_PARM(verbose, "i");
MODULE_PARM(major, "i");
MODULE_PARM(name, "s");
@@ -255,7 +234,7 @@
struct gendisk *gd;
};
-struct pd_unit pd[PD_UNITS];
+static struct pd_unit pd[PD_UNITS];
static char pd_scratch[512]; /* scratch block buffer */
--- linux-2.6.10-rc2-mm3-full/drivers/block/paride/pf.c.old 2004-11-24 23:46:55.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/block/paride/pf.c 2004-11-24 23:47:06.000000000 +0100
@@ -156,27 +156,6 @@
static spinlock_t pf_spin_lock;
-#ifndef MODULE
-
-#include "setup.h"
-
-static STT pf_stt[7] = {
- {"drive0", 7, drive0},
- {"drive1", 7, drive1},
- {"drive2", 7, drive2},
- {"drive3", 7, drive3},
- {"disable", 1, &disable},
- {"cluster", 1, &cluster},
- {"nice", 1, &nice}
-};
-
-void pf_setup(char *str, int *ints)
-{
- generic_setup(pf_stt, 7, str);
-}
-
-#endif
-
MODULE_PARM(verbose, "i");
MODULE_PARM(major, "i");
MODULE_PARM(name, "s");
@@ -256,7 +235,7 @@
struct gendisk *disk;
};
-struct pf_unit units[PF_UNITS];
+static struct pf_unit units[PF_UNITS];
static int pf_identify(struct pf_unit *pf);
static void pf_lock(struct pf_unit *pf, int func);
--- linux-2.6.10-rc2-mm3-full/drivers/block/paride/pg.c.old 2004-11-24 23:47:06.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/block/paride/pg.c 2004-11-24 23:47:19.000000000 +0100
@@ -165,25 +165,6 @@
#include <asm/uaccess.h>
-#ifndef MODULE
-
-#include "setup.h"
-
-static STT pg_stt[5] = {
- {"drive0", 6, drive0},
- {"drive1", 6, drive1},
- {"drive2", 6, drive2},
- {"drive3", 6, drive3},
- {"disable", 1, &disable}
-};
-
-void pg_setup(char *str, int *ints)
-{
- generic_setup(pg_stt, 5, str);
-}
-
-#endif
-
MODULE_PARM(verbose, "i");
MODULE_PARM(major, "i");
MODULE_PARM(name, "s");
@@ -235,7 +216,7 @@
char name[PG_NAMELEN]; /* pg0, pg1, ... */
};
-struct pg devices[PG_UNITS];
+static struct pg devices[PG_UNITS];
static int pg_identify(struct pg *dev, int log);
--- linux-2.6.10-rc2-mm3-full/drivers/block/paride/pt.c.old 2004-11-24 23:47:19.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/block/paride/pt.c 2004-11-24 23:47:30.000000000 +0100
@@ -149,26 +149,6 @@
#include <asm/uaccess.h>
-#ifndef MODULE
-
-#include "setup.h"
-
-static STT pt_stt[5] = {
- {"drive0", 6, drive0},
- {"drive1", 6, drive1},
- {"drive2", 6, drive2},
- {"drive3", 6, drive3},
- {"disable", 1, &disable}
-};
-
-void
-pt_setup(char *str, int *ints)
-{
- generic_setup(pt_stt, 5, str);
-}
-
-#endif
-
MODULE_PARM(verbose, "i");
MODULE_PARM(major, "i");
MODULE_PARM(name, "s");
@@ -246,7 +226,7 @@
static int pt_identify(struct pt_unit *tape);
-struct pt_unit pt[PT_UNITS];
+static struct pt_unit pt[PT_UNITS];
static char pt_scratch[512]; /* scratch block buffer */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--- linux-2.6.10-rc1-mm3-full/drivers/block/paride/setup.h 2004-10-18 23:55:27.000000000 +0200
+++ /dev/null 2004-08-23 02:01:39.000000000 +0200
@@ -1,69 +0,0 @@
-/*
- setup.h (c) 1997-8 Grant R. Guenther <grant@torque.net>
- Under the terms of the GNU General Public License.
-
- This is a table driven setup function for kernel modules
- using the module.variable=val,... command line notation.
-
-*/
-
-/* Changes:
-
- 1.01 GRG 1998.05.05 Allow negative and defaulted values
-
-*/
-
-#include <linux/ctype.h>
-#include <linux/string.h>
-
-struct setup_tab_t {
-
- char *tag; /* variable name */
- int size; /* number of elements in array */
- int *iv; /* pointer to variable */
-};
-
-typedef struct setup_tab_t STT;
-
-/* t is a table that describes the variables that can be set
- by gen_setup
- n is the number of entries in the table
- ss is a string of the form:
-
- <tag>=[<val>,...]<val>
-*/
-
-static void generic_setup( STT t[], int n, char *ss )
-
-{ int j,k, sgn;
-
- k = 0;
- for (j=0;j<n;j++) {
- k = strlen(t[j].tag);
- if (strncmp(ss,t[j].tag,k) == 0) break;
- }
- if (j == n) return;
-
- if (ss[k] == 0) {
- t[j].iv[0] = 1;
- return;
- }
-
- if (ss[k] != '=') return;
- ss += (k+1);
-
- k = 0;
- while (ss && (k < t[j].size)) {
- if (!*ss) break;
- sgn = 1;
- if (*ss == '-') { ss++; sgn = -1; }
- if (!*ss) break;
- if (isdigit(*ss))
- t[j].iv[k] = sgn * simple_strtoul(ss,NULL,0);
- k++;
- if ((ss = strchr(ss,',')) != NULL) ss++;
- }
-}
-
-/* end of setup.h */
-
next prev parent reply other threads:[~2004-11-29 12:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 23:10 [2.6 patch] drivers/block/: some cleanups Adrian Bunk
2004-11-25 10:12 ` Christoph Hellwig
2004-11-29 12:04 ` Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/genhd.c: make a function static Adrian Bunk
2004-11-29 12:26 ` Adrian Bunk [this message]
2004-11-29 12:26 ` [2.6 patch] misc drivers/block/cciss* cleanups Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/cpqarray.c: small cleanups Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/elevator.c: make two functions static Adrian Bunk
2004-11-29 19:36 ` Jens Axboe
2004-11-29 12:26 ` [2.6 patch] floppy.c: make some code static Adrian Bunk
2004-11-29 12:28 ` [2.6 patch] loop.c: make two functions static Adrian Bunk
2004-11-29 12:29 ` [2.6 patch] drivers/block/nbd.c: make some " Adrian Bunk
2004-11-29 12:31 ` [2.6 patch] noop-iosched.c: " Adrian Bunk
2004-11-29 19:36 ` Jens Axboe
2004-11-29 12:33 ` [2.6 patch] drivers/block/pktcdvd.c: make two " Adrian Bunk
2004-11-29 19:33 ` Peter Osterlund
2004-11-29 12:35 ` [2.6 patch] drivers/block/ps2esdi.c: remove two unused functions Adrian Bunk
2004-11-29 12:36 ` [2.6 patch] drivers/block/rd.c: make two variables static Adrian Bunk
2004-11-29 12:37 ` [2.6 patch] drivers/block/ub.c: make a struct static Adrian Bunk
2004-11-29 16:14 ` Pete Zaitcev
2005-02-24 21:56 ` Adrian Bunk
2004-11-29 12:39 ` [2.6 patch] drivers/block/umem.c: make two functions static Adrian Bunk
2004-11-29 12:40 ` [2.6 patch] drivers/block/xd.c: make a variable static Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-01-29 13:35 [2.6 patch] drivers/block/paride/ cleanups Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129122625.GF9722@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox