From: Greg KH <greg@kroah.com>
To: Daniel Ritz <daniel.ritz@gmx.ch>
Cc: Dmitry Torokhov <dtor_core@ameritech.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] touchkitusb: module_param to swap axes
Date: Mon, 29 Nov 2004 11:07:39 -0800 [thread overview]
Message-ID: <20041129190739.GD15452@kroah.com> (raw)
In-Reply-To: <200411252118.17690.daniel.ritz@gmx.ch>
On Thu, Nov 25, 2004 at 09:18:17PM +0100, Daniel Ritz wrote:
> On Thursday 25 November 2004 06:10, Dmitry Torokhov wrote:
> > On Wednesday 24 November 2004 04:28 pm, Daniel Ritz wrote:
> > > add a module parameter to swap the axes. many displays need this...
> > >
> > > --- 1.2/drivers/usb/input/touchkitusb.c 2004-09-18 10:07:25 +02:00
> > > +++ edited/drivers/usb/input/touchkitusb.c 2004-11-24 18:57:59 +01:00
> > > @@ -59,6 +59,10 @@
> > > #define DRIVER_AUTHOR "Daniel Ritz <daniel.ritz@gmx.ch>"
> > > #define DRIVER_DESC "eGalax TouchKit USB HID Touchscreen Driver"
> > >
> > > +static int swap_xy;
> > > +module_param(swap_xy, bool, 0);
> >
> > It looks it can easily be exported to userspace to allow switching "on-fly"
> > since it is checked for every packet. I think 0600 will do.
> >
>
> agreed. and when 0600 is ok, i guess 0644 is ok too.
Applied, thanks.
greg k-h
prev parent reply other threads:[~2004-11-29 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 21:28 [PATCH 2.6] touchkitusb: module_param to swap axes Daniel Ritz
2004-11-25 5:10 ` Dmitry Torokhov
2004-11-25 20:18 ` Daniel Ritz
2004-11-29 19:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129190739.GD15452@kroah.com \
--to=greg@kroah.com \
--cc=daniel.ritz@gmx.ch \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox