From: Roger Luethi <rl@hellgate.ch>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/via-rhine: convert MODULE_PARM to module_param
Date: Tue, 30 Nov 2004 23:04:10 +0100 [thread overview]
Message-ID: <20041130220410.GB29947@k3.hellgate.ch> (raw)
In-Reply-To: <Pine.LNX.4.61.0411302241260.3635@dragon.hygekrogen.localhost>
On Tue, 30 Nov 2004 22:44:37 +0100, Jesper Juhl wrote:
> already moved to module_param(). There's one difference though, and I
> think it matters; my patch sets the permission bits so that the parameters
> get exposed in sysfs (which I think is very useful), the driver in -mm
> sets the perms to 0 (zero) so nothing is exposed in sysfs (less useful).
I am not familiar with the issue. Can you work out with the submitter of
the -mm patch why it was coded that way, and if your version is better?
Roger
prev parent reply other threads:[~2004-11-30 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 23:58 [PATCH] net/via-rhine: convert MODULE_PARM to module_param Jesper Juhl
2004-11-30 14:03 ` Roger Luethi
2004-11-30 21:44 ` Jesper Juhl
2004-11-30 22:04 ` Roger Luethi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130220410.GB29947@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox