Re: [PATCH 2.6] via-rhine: WOL band-aid

Jeff Garzik
2004-11-30T23:26:19Z

Roger Luethi wrote:
> After I disabled legacy WOL (i.e. controlled by EEPROM rather than
> driver) in 2.6.9, several people reported regressions. Legacy WOL had
> worked for them, but now it didn't anymore. The Right Way (TM) to fix
> this will get the driver to set up working WOL for all hardware, but a
> simpler solution will have to do for the time being: If a user requests
> magic packet WOL, the driver re-enables legacy WOL. Yeah, I know it's
> cheating.
>
> This version applies against -mm. I suggest to put it there for testing
> and into 2.6.11 if feedback is good.
>
> Thanks to Pavel Ruzicka for testing.

I don't object to the patch, but I wonder if anything can be done to
reduce the usage of "magic numbers" (numeric rather than named constants)?

Jeff