From: Roger Luethi <rl@hellgate.ch>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6] via-rhine: WOL band-aid
Date: Wed, 1 Dec 2004 00:45:26 +0100 [thread overview]
Message-ID: <20041130234526.GA32741@k3.hellgate.ch> (raw)
In-Reply-To: <41ACFFA0.2030904@pobox.com>
On Tue, 30 Nov 2004 18:17:52 -0500, Jeff Garzik wrote:
> I don't object to the patch, but I wonder if anything can be done to
> reduce the usage of "magic numbers" (numeric rather than named constants)?
That's a non-trivial task if you want to do it properly. There be dragons.
Magic numbers may be evil but at least they are honest and convenient.
Roger
next prev parent reply other threads:[~2004-11-30 23:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 22:40 [PATCH 2.6] via-rhine: WOL band-aid Roger Luethi
2004-11-30 23:17 ` Jeff Garzik
2004-11-30 23:45 ` Roger Luethi [this message]
2004-12-02 22:40 ` Jeff Garzik
2004-12-01 0:46 ` [PATCH 2.6] via-rhine: WOL band-aid (patch against 2.6.9) Sven Ladegast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130234526.GA32741@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox