From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] dm: remove unused functions (fwd)
Date: Wed, 1 Dec 2004 05:54:22 +0100 [thread overview]
Message-ID: <20041201045422.GF2650@stusta.de> (raw)
In-Reply-To: <20041130230525.GC24233@agk.surrey.redhat.com>
On Tue, Nov 30, 2004 at 11:05:25PM +0000, Alasdair G Kergon wrote:
> On Mon, Nov 29, 2004 at 03:29:40AM +0100, Adrian Bunk wrote:
> > Please apply or comment on it.
>
> Please check *why* the functions aren't used first.
>
> e.g. An alloc function with a corresponding free that
> never gets called suggests a leak to me...
I have to admit that I don't thoroughly check the code where I find
unused code. That's why I asked for comments on this patch. Ususally the
maintainers of the code in question know best whether such a patch is
correct or not.
Simply consider my patches as some kind of "list of unused functions".
> Alasdair
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-12-01 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 2:29 [2.6 patch] dm: remove unused functions (fwd) Adrian Bunk
2004-11-30 23:05 ` Alasdair G Kergon
2004-12-01 4:54 ` Adrian Bunk [this message]
2004-12-01 14:41 ` [dm-devel] " Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041201045422.GF2650@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox