From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261435AbULAUhU (ORCPT ); Wed, 1 Dec 2004 15:37:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261436AbULAUhU (ORCPT ); Wed, 1 Dec 2004 15:37:20 -0500 Received: from mail-relay-2.tiscali.it ([213.205.33.42]:38360 "EHLO mail-relay-2.tiscali.it") by vger.kernel.org with ESMTP id S261435AbULAUhN (ORCPT ); Wed, 1 Dec 2004 15:37:13 -0500 Date: Wed, 1 Dec 2004 21:37:12 +0100 From: Kronos To: linux-fbdev-devel@lists.sourceforge.net Cc: Marcelo Tosatti , Linux Kernel Development Subject: Re: [PATCH 2.4.29-pre1] radeonfb: don't try to ioreamp the entire VRAM [was: Re: [Linux-fbdev-devel] why does radeonfb work fine in 2.6, but not in 2.4.29-pre1?] Message-ID: <20041201203711.GA21008@dreamland.darkstar.lan> References: <20041128184606.GA2537@middle.of.nowhere> <20041201161455.GA14817@dreamland.darkstar.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Il Wed, Dec 01, 2004 at 05:25:52PM +0100, Geert Uytterhoeven ha scritto: > > Make fb layer aware of the difference between the ioremap()'ed VRAM and > > total available VRAM. > > smem_len in struct fb_fix_screeninfo still contains the amount of > > physical VRAM (reported to userspace via FBIOGET_FSCREENINFO ioctl) and > > the new field mapped_vram contains the amount of VRAM actually > > ioremap()'ed by drivers (used in read/write/mmap operations). > > Since there was unused padding at the end of struct fb_fix_screeninfo > > binary compatibility with userspace utilities is retained. > > If mapped_vram is not set it's assumed that the entire framebuffer is > > mapped, thus other drivers are unaffected by this patch. > > > > The patch has been tested by Jurriaan . > > > > Signed-off-by: Luca Tettamanti > > > > --- a/include/linux/fb.h 2004-11-30 18:30:08.000000000 +0100 > > +++ b/include/linux/fb.h 2004-11-30 18:33:00.000000000 +0100 > > @@ -126,7 +126,8 @@ > > /* (physical address) */ > > __u32 mmio_len; /* Length of Memory Mapped I/O */ > > __u32 accel; /* Type of acceleration available */ > > - __u16 reserved[3]; /* Reserved for future compatibility */ > > + __u32 mapped_vram; /* Amount of ioremap()'ed VRAM */ > > + __u16 reserved[1]; /* Reserved for future compatibility */ > > }; > > I don't really like this patch. mapped_vram doesn't matter for user space at > all, so it does not belong to fb_fix_screeninfo. Hmm, it looked sensible to me since it's the max amount of data that userspace can read (or write) from /dev/fb%d. Putting mapped_vram in fb_info would be acceptable? Luca -- Home: http://kronoz.cjb.net Carpe diem, quam minimum credula postero. (Q. Horatius Flaccus)