From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261475AbULAWed (ORCPT ); Wed, 1 Dec 2004 17:34:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261474AbULAWed (ORCPT ); Wed, 1 Dec 2004 17:34:33 -0500 Received: from mail-relay-1.tiscali.it ([213.205.33.41]:9094 "EHLO mail-relay-1.tiscali.it") by vger.kernel.org with ESMTP id S261475AbULAWdh (ORCPT ); Wed, 1 Dec 2004 17:33:37 -0500 Date: Wed, 1 Dec 2004 23:33:24 +0100 From: Andrea Arcangeli To: Thomas Gleixner Cc: Andrew Morton , marcelo.tosatti@cyclades.com, LKML Subject: Re: [PATCH] oom killer (Core) Message-ID: <20041201223324.GC4530@dualathlon.random> References: <20041201104820.1.patchmail@tglx> <20041201211638.GB4530@dualathlon.random> <1101938767.13353.62.camel@tglx.tec.linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1101938767.13353.62.camel@tglx.tec.linutronix.de> X-GPG-Key: 1024D/68B9CB43 13D9 8355 295F 4823 7C49 C012 DFA1 686E 68B9 CB43 X-PGP-Key: 1024R/CB4660B9 CC A0 71 81 F4 A0 63 AC C0 4B 81 1D 8C 15 C8 E5 User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 01, 2004 at 11:06:07PM +0100, Thomas Gleixner wrote: > On Wed, 2004-12-01 at 22:16 +0100, Andrea Arcangeli wrote: > > On Wed, Dec 01, 2004 at 10:49:03AM +0100, tglx@linutronix.de wrote: > > > It gets invoked multiple times [..] > > > > You didn't move the invocation in page_alloc.c which is the major bug I > > can see (besides the other hacks in oom_kill.c). I'd try fixing the > > major bug first. > > Where do you want to move it ? > > I don't buy that moving the invocation to any place will solve the > problem of multiple invocations. It has to check the levels of free memory before calling oom_kill.c and that's the usual check that alloc_pages does.