From: Arnd Bergmann <arnd@arndb.de>
To: Jan Kasprzak <kas@fi.muni.cz>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cosa.h ioctl numbers
Date: Thu, 2 Dec 2004 13:58:00 +0100 [thread overview]
Message-ID: <200412021358.00844.arnd@arndb.de> (raw)
In-Reply-To: <20041202124456.GF11992@fi.muni.cz>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Dunnersdag 02 Dezember 2004 13:44, Jan Kasprzak wrote:
> The following patch reverts the changes in ioctl() numbers
> for COSA WAN card, makink the ioctl numbers the same as in 2.4, and thus
> preserving the binary compatibility with user-space utils.
> /* Read the block from the device memory */
> -#define COSAIORMEM _IOWR('C',0xf2, struct cosa_download)
> +#define COSAIORMEM _IOWR('C',0xf2, struct cosa_download *)
>
> /* Write the block to the device memory (i.e. download the microcode) */
> -#define COSAIODOWNLD _IOW('C',0xf2, struct cosa_download)
> +#define COSAIODOWNLD _IOW('C',0xf2, struct cosa_download *)
Isn't that rather misleading? I suppose the real argument is
'struct cosa_download', so you should have some kind of comment there,
e.g.
#define COSAIODOWNLD _IOW('C',0xf2, long) /* actually struct cosa_download */
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-12-02 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-02 12:44 [PATCH] cosa.h ioctl numbers Jan Kasprzak
2004-12-02 12:58 ` Arnd Bergmann [this message]
2004-12-02 13:12 ` Jan Kasprzak
2004-12-02 13:57 ` Andreas Schwab
2004-12-02 14:11 ` Jan Kasprzak
2004-12-02 15:13 ` Andreas Schwab
2004-12-02 15:50 ` Linus Torvalds
2005-01-06 10:02 ` Jan Kasprzak
2004-12-02 15:56 ` Jan Kasprzak
2004-12-02 16:45 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412021358.00844.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox