public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Block layer question - indicating EOF on block devices
Date: Thu, 2 Dec 2004 15:07:31 +0100	[thread overview]
Message-ID: <20041202140730.GH10458@suse.de> (raw)
In-Reply-To: <1101992502.5624.8.camel@localhost.localdomain>

On Thu, Dec 02 2004, Alan Cox wrote:
> On Iau, 2004-12-02 at 08:18, Jens Axboe wrote:
> > The upper buffer layer could do something intelligent if EOF is set on
> > the bio, it really should. The problem is that there's no -EXXX to flag
> > EOF from the driver, it would be nicest if one could just do:
> > 
> > 	end_that_request_chunk(req, 1, good_bytes);
> > 	end_that_request_chunk(req, -EOF, residual);
> > 
> 
> We have a set of internal error codes around -512 for things like
> "please use
> the default ioctl behaviour". The error codes don't seem to get
> propogated up through the page cache however when I tried using this (I
> just "borrowed"
> -ENOMEDIUM for testing) with the idea of catching it at the top.

It gets passed to the bio->bi_end_io end io handler, but most likely
that doesn't do anything with it (most just treat it as a bool). That's
where the improvement room is, basically :)

-- 
Jens Axboe


      reply	other threads:[~2004-12-02 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-30 15:50 Block layer question - indicating EOF on block devices Alan Cox
2004-12-01  2:43 ` Andrew Morton
2004-12-01 14:54   ` Alan Cox
2004-12-02  8:18     ` Jens Axboe
2004-12-02 13:01       ` Alan Cox
2004-12-02 14:07         ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041202140730.GH10458@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox