From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261777AbULBVJl (ORCPT ); Thu, 2 Dec 2004 16:09:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261771AbULBVIE (ORCPT ); Thu, 2 Dec 2004 16:08:04 -0500 Received: from honk1.physik.uni-konstanz.de ([134.34.140.224]:49575 "EHLO honk1.physik.uni-konstanz.de") by vger.kernel.org with ESMTP id S261769AbULBVEu (ORCPT ); Thu, 2 Dec 2004 16:04:50 -0500 Date: Thu, 2 Dec 2004 21:56:03 +0100 From: Guido Guenther To: Pavel Machek Cc: hugang@soulinfo.com, linux-kernel@vger.kernel.org Subject: Re: software suspend patch [1/6] Message-ID: <20041202205603.GA8030@bogon.ms20.nix> References: <20041127220752.16491.qmail@science.horizon.com> <20041128082912.GC22793@wiggy.net> <20041128113708.GQ1417@openzaurus.ucw.cz> <20041128162320.GA28881@hugang.soulinfo.com> <20041128162558.GF28881@hugang.soulinfo.com> <20041128171106.GD1214@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041128171106.GD1214@elf.ucw.cz> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 28, 2004 at 06:11:06PM +0100, Pavel Machek wrote: > Hi! > > > > device-tree.diff > > > base from suspend2 with a little changed. > > > > > > core.diff > > > 1: redefine struct pbe for using _no_ continuous as pagedir. > > > 2: make shrink memory as little as possible. > > > 3: using a bitmap speed up collide check in page relocating. > > > 4: pagecache saving ready. > > > > > > i386.diff > > > ppc.diff > > > i386 and powerpc suspend update. > > > > > > pagecachs_addon.diff > > > if enable page caches saving, must using it, it making saving > > > pagecaches safe. idea from suspend2. > > > > > > ppcfix.diff > > > fix compile error. > > > $ gcc -v > > > .... > > > gcc version 2.95.4 20011002 (Debian prerelease) > > > > > > I'm using 2.6.9-ck3 With above patch, swsusp1 works prefect in my > > > PowerPC and x86 PC with Highmem and prepempt option enabled. > > > > > > I hope the core.diff@1,@2,@3 i386.diff ppc.diff will merge into > > > mainline kernel ASAP, :). from I view point device-tree.diff is > > > very usefuly when using pagecache saving and pagecachs_addon.diff > > > that's really hack for making pagecache saving safe. > > > > > > > --- 2.6.9-lzf/arch/ppc/syslib/open_pic.c 2004-11-26 12:32:58.000000000 +0800 > > +++ 2.6.9/arch/ppc/syslib/open_pic.c 2004-11-28 23:16:58.000000000 +0800 > > @@ -776,7 +776,8 @@ static void openpic_mapirq(u_int irq, cp > > if (ISR[irq] == 0) > > return; > > if (!cpus_empty(keepmask)) { > > - cpumask_t irqdest = { .bits[0] = openpic_read(&ISR[irq]->Destination) }; > > + cpumask_t irqdest; > > + irqdest.bits[0] = openpic_read(&ISR[irq]->Destination); > > cpus_and(irqdest, irqdest, keepmask); > > cpus_or(physmask, physmask, irqdest); > > } Doesn't the former mean initialize irqdest.bits as a whole to zero and .bits[0] to openpic_read(...), while the later only sets iqdest.bits[0] to openpic_read(...)? I think this is wrong. Cheers, -- Guido