public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eugene Surovegin <ebs@ebshome.net>
To: Linh Dang <dang.linh@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][PPC32[NEWBIE] enhancement to virt_to_bus/bus_to_virt (try 2)
Date: Sun, 5 Dec 2004 12:52:51 -0800	[thread overview]
Message-ID: <20041205205251.GD3448@gate.ebshome.net> (raw)
In-Reply-To: <3b2b320041205111821527278@mail.gmail.com>

On Sun, Dec 05, 2004 at 02:18:45PM -0500, Linh Dang wrote:
> From a single virtual buffer, the DMA library will build a chained list of
> physically contiguous buffers (it  can be one or more physical buffers).
> All the DMA engines I'm familiar with (mpc8260, mpc8580, marvell, etc.)
> accept a list of physical buffers.
> 
> The decoding algorithm (from a single virtual buffer to a chained list of
> physical buffers) is dead simple.

So you gonna call virt_to_bus several times (for each page) and see 
whether you get new phys page or not? This could work, but for the 
common case of phys-continuous buffer it'll be suboptimal, i.e. you 
waste time calling virt_to_bus when it's not needed. TO make it better 
you have to move that range check from virt_to_bus and friends to your 
DMA library, in this case we end up in the same situation we are 
already :) - no need to modify virt_to_bus....

--
Eugene

  reply	other threads:[~2004-12-05 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-02 14:49 [PATCH][PPC32] enhancement to virt_to_bus/bus_to_virt (resent with spell-checked subject line) Linh Dang
2004-12-02 16:28 ` [PATCH][PPC32[NEWBIE] enhancement to virt_to_bus/bus_to_virt (try 2) Linh Dang
2004-12-02 20:31   ` Paul Mackerras
2004-12-03 14:46     ` Linh Dang
2004-12-05 10:11       ` Eugene Surovegin
2004-12-05 19:18         ` Linh Dang
2004-12-05 20:52           ` Eugene Surovegin [this message]
2004-12-05 21:12       ` Paul Mackerras
2004-12-06  1:31         ` Linh Dang
2004-12-06  1:56         ` Linh Dang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041205205251.GD3448@gate.ebshome.net \
    --to=ebs@ebshome.net \
    --cc=dang.linh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox