public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Tomasz K?oczko <kloczek@rudy.mif.pg.gda.pl>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/char/moxa.c: #if 0 an unused function
Date: Mon, 6 Dec 2004 01:41:30 +0100	[thread overview]
Message-ID: <20041206004130.GI2953@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.61L.0412052112080.11466@rudy.mif.pg.gda.pl>

On Sun, Dec 05, 2004 at 09:14:08PM +0100, Tomasz K?oczko wrote:
>...
> >- *	5.  MoxaPortGetCurBaud(int port);				     
> >*
> > *	6.  MoxaPortSetBaud(int port, long baud);			     
> > *
> > *	7.  MoxaPortSetMode(int port, int databit, int stopbit, int parity); 
> > *
> > *	8.  MoxaPortSetTermio(int port, unsigned char *termio); 	     
> > *
> [..]
> 
> Prabaly it will be good renumber this or make unnumbered (and all other 
> comments with "Function <num>:" :)


Perhaps the following patch is the best solution:


diffstat output:
 drivers/char/moxa.c |    2 ++
 1 files changed, 2 insertions(+)


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c.old	2004-12-06 01:30:18.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c	2004-12-06 01:30:39.000000000 +0100
@@ -3090,6 +3090,7 @@
 	return (0);
 }
 
+#if 0
 long MoxaPortGetCurBaud(int port)
 {
 
@@ -3097,6 +3098,7 @@
 		return (0);
 	return (moxaCurBaud[port]);
 }
+#endif  /*  0  */
 
 static void MoxaSetFifo(int port, int enable)
 {




  reply	other threads:[~2004-12-06  0:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-05 17:02 [2.6 patch] drivers/char/moxa.c: remove an unused function Adrian Bunk
2004-12-05 20:14 ` Tomasz Kłoczko
2004-12-06  0:41   ` Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-01-23 10:17 [2.6 patch] drivers/char/moxa.c: #if 0 " Adrian Bunk
2005-01-24 13:09 ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041206004130.GI2953@stusta.de \
    --to=bunk@stusta.de \
    --cc=kloczek@rudy.mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox