public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andries Brouwer <Andries.Brouwer@cwi.nl>
To: Martin Pool <mbp@sourcefrog.net>,
	Andries.Brouwer@cwi.nl, linux-kernel@vger.kernel.org
Subject: Re: rescan partitions returns EIO since 2.6.8
Date: Mon, 6 Dec 2004 02:50:53 +0100	[thread overview]
Message-ID: <20041206015052.GC4734@apps.cwi.nl> (raw)
In-Reply-To: <20041206004722.GD26060@hp.com>

On Mon, Dec 06, 2004 at 11:47:22AM +1100, Martin Pool wrote:
> On  5 Dec 2004, Andries.Brouwer@cwi.nl wrote:
> > Martin Pool changed the behaviour of the BLKRRPART ioctl in 2.6.8.
> > The effect is that one now gets an I/O error when first
> > partitioning an empty disk:
> 
> > # sfdisk /dev/sda
> > Checking that no-one is using this disk right now ...
> > BLKRRPART: Input/output error
> 
> To me it seems more correct that a request to read the partition table
> should fail if the partition table can't be read.

I do not view BLKRRPART as a request to read the partition table.
It is a request to revalidate: "if the disk is in use, return EBUSY,
otherwise, discard any old information, read any new information".
If the disk is blank then there is no new information to read,
that is not an error, and certainly not an I/O error.

> if you really want to roll it back I won't object.

Yes, I think I want to - am getting worried mail from people
who very much dislike I/O errors on a brand-new disk.

Andries

  reply	other threads:[~2004-12-06  1:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-05 14:03 rescan partitions returns EIO since 2.6.8 Andries.Brouwer
2004-12-06  0:47 ` Martin Pool
2004-12-06  1:50   ` Andries Brouwer [this message]
2004-12-14  6:31     ` Martin Pool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041206015052.GC4734@apps.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbp@sourcefrog.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox