From: Dimitri Sivanich <sivanich@sgi.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Jesse Barnes <jbarnes@sgi.com>,
piggin@cyberone.com.au
Subject: [PATCH] isolcpus option broken in 2.6.10-rc2-bk2
Date: Mon, 6 Dec 2004 12:52:21 -0600 [thread overview]
Message-ID: <20041206185221.GA23917@sgi.com> (raw)
The isolcpus option is broken in 2.6.10-rc2-bk2. The domains are no longer
being properly initialized (which results in a panic at bootup).
The following patch fixes this.
Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
Index: linux/arch/ia64/kernel/domain.c
===================================================================
--- linux.orig/arch/ia64/kernel/domain.c 2004-12-03 15:43:47.000000000 -0600
+++ linux/arch/ia64/kernel/domain.c 2004-12-06 12:28:42.788584850 -0600
@@ -220,6 +220,23 @@ void __devinit arch_init_sched_domains(v
&cpu_to_phys_group);
}
+ /* Initialize isolated CPU (physical) domains and groups */
+ for_each_cpu_mask(i, cpu_isolated_map) {
+ struct sched_domain *sd = NULL;
+ int group;
+
+ sd = &per_cpu(phys_domains, i);
+ group = cpu_to_phys_group(i);
+ *sd = SD_CPU_INIT;
+ cpu_set(i, sd->span);
+ sd->flags = 0;
+ sd->balance_interval = INT_MAX;
+ sd->groups = &sched_group_phys[group];
+ init_sched_build_groups(sched_group_phys, sd->span,
+ &cpu_to_phys_group);
+ sd->groups->cpu_power = SCHED_LOAD_SCALE;
+ }
+
#ifdef CONFIG_NUMA
init_sched_build_groups(sched_group_allnodes, cpu_default_map,
&cpu_to_allnodes_group);
Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c 2004-12-03 15:44:08.000000000 -0600
+++ linux/kernel/sched.c 2004-12-06 12:28:35.359689609 -0600
@@ -4323,6 +4323,23 @@ static void __devinit arch_init_sched_do
&cpu_to_phys_group);
}
+ /* Initialize isolated CPU (physical) domains and groups */
+ for_each_cpu_mask(i, cpu_isolated_map) {
+ struct sched_domain *sd = NULL;
+ int group;
+
+ sd = &per_cpu(phys_domains, i);
+ group = cpu_to_phys_group(i);
+ *sd = SD_CPU_INIT;
+ cpu_set(i, sd->span);
+ sd->flags = 0;
+ sd->balance_interval = INT_MAX;
+ sd->groups = &sched_group_phys[group];
+ init_sched_build_groups(sched_group_phys, sd->span,
+ &cpu_to_phys_group);
+ sd->groups->cpu_power = SCHED_LOAD_SCALE;
+ }
+
#ifdef CONFIG_NUMA
/* Set up node groups */
init_sched_build_groups(sched_group_nodes, cpu_default_map,
next reply other threads:[~2004-12-06 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 18:52 Dimitri Sivanich [this message]
2004-12-06 21:18 ` [PATCH] isolcpus option broken in 2.6.10-rc2-bk2 Ingo Molnar
2004-12-08 8:57 ` Nick Piggin
2004-12-08 9:04 ` Ingo Molnar
2004-12-07 22:59 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041206185221.GA23917@sgi.com \
--to=sivanich@sgi.com \
--cc=akpm@osdl.org \
--cc=jbarnes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox