From: Adrian Bunk <bunk@stusta.de>
To: Riina Kikas <riinak@ut.ee>
Cc: linux-kernel@vger.kernel.org, mroos@ut.ee
Subject: Re: [PATCH 2.6] clean-up: fixes "shadows global" warning
Date: Mon, 6 Dec 2004 22:41:23 +0100 [thread overview]
Message-ID: <20041206214123.GL7250@stusta.de> (raw)
In-Reply-To: <Pine.SOC.4.61.0412062251140.21075@math.ut.ee>
On Mon, Dec 06, 2004 at 10:52:58PM +0200, Riina Kikas wrote:
> This patch fixes warning "declaration of `errno' shadows a global
> declaration"
> occuring on line 102
>
> Signed-off-by: Riina Kikas <Riina.Kikas@mail.ee>
>
> --- a/include/linux/nfsd/export.h 2004-08-14 10:55:33.000000000 +0000
> +++ b/include/linux/nfsd/export.h 2004-10-31 19:01:15.000000000 +0000
> @@ -99,7 +99,7 @@
> int exp_rootfh(struct auth_domain *,
> char *path, struct knfsd_fh *, int
> maxsize);
> int exp_pseudoroot(struct auth_domain *, struct svc_fh
> *fhp, struct cache_req *creq);
> -int nfserrno(int errno);
> +int nfserrno(int errno_l);
>
> extern void expkey_put(struct cache_head *item, struct cache_detail *cd);
> extern void svc_export_put(struct cache_head *item, struct cache_detail
> *cd);
It doesn't make much sense to change the name in the prototype in the
header file but not in the actual file.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-12-06 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 20:52 [PATCH 2.6] clean-up: fixes "shadows global" warning Riina Kikas
2004-12-06 21:41 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-06 21:00 Riina Kikas
2004-12-06 21:01 Riina Kikas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041206214123.GL7250@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@ut.ee \
--cc=riinak@ut.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox