From: Gerd Knorr <kraxel@bytesex.org>
To: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
uml devel <user-mode-linux-devel@lists.sourceforge.net>,
Jeff Dike <jdike@addtoit.com>,
Blaisorblade <blaisorblade_spam@yahoo.it>
Subject: [patch] uml: fix umldir init order
Date: Tue, 7 Dec 2004 15:37:11 +0100 [thread overview]
Message-ID: <20041207143711.GA23612@bytesex> (raw)
Fixup initialization order when creating the $HOME/.uml/<umid>
directory and the files therein, also make the error messages
more useful.
Signed-off-by: Gerd Knorr <kraxel@bytesex.org>
---
arch/um/kernel/umid.c | 19 +++++++++----------
1 files changed, 9 insertions(+), 10 deletions(-)
Index: uml-2.6.9-rc2/arch/um/kernel/umid.c
===================================================================
--- uml-2.6.9-rc2.orig/arch/um/kernel/umid.c 2004-09-16 16:34:52.644479658 +0200
+++ uml-2.6.9-rc2/arch/um/kernel/umid.c 2004-09-16 16:37:09.347268895 +0200
@@ -92,8 +92,8 @@ static int __init create_pid_file(void)
fd = os_open_file(file, of_create(of_excl(of_rdwr(OPENFLAGS()))),
0644);
if(fd < 0){
- printf("Open of machine pid file \"%s\" failed - "
- "err = %d\n", file, -fd);
+ printf("Open of machine pid file \"%s\" failed: %s\n",
+ file, strerror(-fd));
return 0;
}
@@ -247,7 +247,7 @@ static int __init make_uml_dir(void)
strcpy(uml_dir, dir);
if((mkdir(uml_dir, 0777) < 0) && (errno != EEXIST)){
- printf("Failed to mkdir %s - errno = %i\n", uml_dir, errno);
+ printf("Failed to mkdir %s: %s\n", uml_dir, strerror(errno));
return(-1);
}
return 0;
@@ -264,8 +264,8 @@ static int __init make_umid(int (*printe
strcat(tmp, "XXXXXX");
fd = mkstemp(tmp);
if(fd < 0){
- (*printer)("make_umid - mkstemp failed, errno = %d\n",
- errno);
+ (*printer)("make_umid - mkstemp(%s) failed: %s\n",
+ tmp,strerror(errno));
return(1);
}
@@ -303,15 +303,14 @@ __uml_setup("uml_dir=", set_uml_dir,
" The location to place the pid and umid files.\n\n"
);
-__uml_postsetup(make_uml_dir);
-
static int __init make_umid_setup(void)
{
- return(make_umid(printf));
+ /* one function with the ordering we need ... */
+ make_uml_dir();
+ make_umid(printf);
+ return create_pid_file();
}
-
__uml_postsetup(make_umid_setup);
-__uml_postsetup(create_pid_file);
/*
* Overrides for Emacs so that we follow Linus's tabbing style.
--
#define printk(args...) fprintf(stderr, ## args)
reply other threads:[~2004-12-07 15:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041207143711.GA23612@bytesex \
--to=kraxel@bytesex.org \
--cc=akpm@osdl.org \
--cc=blaisorblade_spam@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox