From: Jens Axboe <axboe@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] bio.c: make bio_destructor static (fwd)
Date: Tue, 7 Dec 2004 20:38:18 +0100 [thread overview]
Message-ID: <20041207193817.GG20010@suse.de> (raw)
In-Reply-To: <20041207193522.GC7250@stusta.de>
On Tue, Dec 07 2004, Adrian Bunk wrote:
> The patch forwarded below still applies and compiles against
> 2.6.10-rc2-mm4.
Patch is correct, thanks.
> ----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----
>
> Date: Sat, 30 Oct 2004 18:44:50 +0200
> From: Adrian Bunk <bunk@stusta.de>
> To: Jens Axboe <axboe@suse.de>
> Cc: linux-kernel@vger.kernel.org
> Subject: [2.6 patch] bio.c: make bio_destructor static
>
>
> bio_destructor in fs/bio.c isn't used outside of this file, and after
> quickly thinking about it I didn't find a reason why it should.
>
> The patch below makes it static.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Acked-by: Jens Axboe <axboe@suse.de>
>
> --- linux-2.6.10-rc1-mm2-full/fs/bio.c.old 2004-10-30 13:53:41.000000000 +0200
> +++ linux-2.6.10-rc1-mm2-full/fs/bio.c 2004-10-30 13:56:16.000000000 +0200
> @@ -91,7 +91,7 @@
> /*
> * default destructor for a bio allocated with bio_alloc()
> */
> -void bio_destructor(struct bio *bio)
> +static void bio_destructor(struct bio *bio)
> {
> const int pool_idx = BIO_POOL_IDX(bio);
> struct biovec_pool *bp = bvec_array + pool_idx;
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
> ----- End forwarded message -----
>
>
--
Jens Axboe
prev parent reply other threads:[~2004-12-07 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-07 19:35 [2.6 patch] bio.c: make bio_destructor static (fwd) Adrian Bunk
2004-12-07 19:38 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041207193817.GG20010@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox