From: Michael Buesch <mbuesch@freenet.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, ck@vds.kolivas.org, kernel@kolivas.org
Subject: Re: [PATCH, RFC] protect call to set_tsk_need_resched() by the rq-lock
Date: Wed, 8 Dec 2004 00:30:58 +0100 [thread overview]
Message-ID: <200412080031.08490.mbuesch@freenet.de> (raw)
In-Reply-To: <20041207131006.GB3710@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
Quoting Ingo Molnar <mingo@elte.hu>:
>
> * Michael Buesch <mbuesch@freenet.de> wrote:
>
> > The two attached patches (one against vanilla kernel and one against
> > ck patchset) moves the rq-lock a few lines up in scheduler_tick() to
> > also protect set_tsk_need_resched().
> >
> > Is that neccessary?
>
> scheduler_tick() is a special case,
> 'current' is pinned and cannot go
> away, nor can it get off the runqueue.
Can you explain in short, why this is the case, please?
I don't really get behind it.
How are the two things enforced?
> So the patch is not needed.
>
> Ingo
Thanks.
--
Regards Michael Buesch [ http://www.tuxsoft.de.vu ]
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-12-07 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 22:39 [PATCH, RFC] protect call to set_tsk_need_resched() by the rq-lock Michael Buesch
2004-12-07 13:10 ` Ingo Molnar
2004-12-07 23:30 ` Michael Buesch [this message]
2004-12-08 8:26 ` Ingo Molnar
2004-12-08 9:49 ` Michael Buesch
2004-12-08 10:29 ` Michael Buesch
2004-12-08 11:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412080031.08490.mbuesch@freenet.de \
--to=mbuesch@freenet.de \
--cc=ck@vds.kolivas.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox