From: Greg Banks <gnb@sgi.com>
To: Philippe Elie <phil.el@wanadoo.fr>
Cc: Greg Banks <gnb@sgi.com>, John Levon <levon@movementarian.org>,
Akinobu Mita <amgta@yacht.ocn.ne.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [mm patch] oprofile: backtrace operation does not initialized
Date: Thu, 9 Dec 2004 11:39:06 +1100 [thread overview]
Message-ID: <20041209003906.GE4239@sgi.com> (raw)
In-Reply-To: <20041208235623.GA563@zaniah>
On Thu, Dec 09, 2004 at 12:56:23AM +0100, Philippe Elie wrote:
>
> oprofile_timer_init doesn't reset op->setup/shutdown, I don't like the idea to
> reset them in oprofile_timer_init() it's error prone. John any idea ?
A better long term solution would be not to change the ops structure
but to copy and chain it, as I did in my experimental cswitch patches.
The approach I took allows for a new fake event which can be selected
at runtime with --event instead of with a boot option.
But for now I don't see any drama with leaving in the ->setup() and
->shutdown() methods when rewriting the ops structure. Ditto for
the ->create_files() methods.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
next prev parent reply other threads:[~2004-12-09 0:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-08 9:30 [mm patch] oprofile: backtrace operation does not initialized Akinobu Mita
2004-12-08 9:34 ` Akinobu Mita
2004-12-08 11:13 ` Ingo Molnar
2004-12-08 11:37 ` Akinobu Mita
2004-12-08 16:00 ` John Levon
2004-12-08 22:31 ` Greg Banks
2004-12-08 23:56 ` Philippe Elie
2004-12-09 0:39 ` Greg Banks [this message]
2004-12-09 1:46 ` John Levon
2004-12-09 1:50 ` Greg Banks
2004-12-09 2:23 ` John Levon
2004-12-09 14:22 ` Akinobu Mita
2004-12-09 14:53 ` Akinobu Mita
2004-12-09 14:55 ` John Levon
2004-12-09 15:27 ` Greg Banks
2004-12-09 15:23 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041209003906.GE4239@sgi.com \
--to=gnb@sgi.com \
--cc=amgta@yacht.ocn.ne.jp \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.el@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox