From: John Levon <levon@movementarian.org>
To: Greg Banks <gnb@sgi.com>
Cc: Philippe Elie <phil.el@wanadoo.fr>,
Akinobu Mita <amgta@yacht.ocn.ne.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [mm patch] oprofile: backtrace operation does not initialized
Date: Thu, 9 Dec 2004 01:46:22 +0000 [thread overview]
Message-ID: <20041209014622.GB48804@compsoc.man.ac.uk> (raw)
In-Reply-To: <20041209003906.GE4239@sgi.com>
On Thu, Dec 09, 2004 at 11:39:06AM +1100, Greg Banks wrote:
> But for now I don't see any drama with leaving in the ->setup() and
> ->shutdown() methods when rewriting the ops structure. Ditto for
> the ->create_files() methods.
Wouldn't this mean that we try to set up the NMI stuff regardless of
forcing the timer ? I can imagine a flaky system where somebody needs to
avoid going near that stuff.
timer_init() making sure to set all fields seems reasonable to me. Or
oprofile_init() could grab ->backtrace, memset the structure, then
replace ->backtrace...
john
next prev parent reply other threads:[~2004-12-09 1:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-08 9:30 [mm patch] oprofile: backtrace operation does not initialized Akinobu Mita
2004-12-08 9:34 ` Akinobu Mita
2004-12-08 11:13 ` Ingo Molnar
2004-12-08 11:37 ` Akinobu Mita
2004-12-08 16:00 ` John Levon
2004-12-08 22:31 ` Greg Banks
2004-12-08 23:56 ` Philippe Elie
2004-12-09 0:39 ` Greg Banks
2004-12-09 1:46 ` John Levon [this message]
2004-12-09 1:50 ` Greg Banks
2004-12-09 2:23 ` John Levon
2004-12-09 14:22 ` Akinobu Mita
2004-12-09 14:53 ` Akinobu Mita
2004-12-09 14:55 ` John Levon
2004-12-09 15:27 ` Greg Banks
2004-12-09 15:23 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041209014622.GB48804@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=amgta@yacht.ocn.ne.jp \
--cc=gnb@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.el@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox