public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: IDE: strange WAIT_READY dependency on APM
Date: Thu, 9 Dec 2004 04:44:38 +0100	[thread overview]
Message-ID: <20041209034438.GF22324@stusta.de> (raw)

IDE contains the following strange code:

<--  snip  -->

#if defined(CONFIG_APM) || defined(CONFIG_APM_MODULE)
#define WAIT_READY      (5*HZ)          /* 5sec - some laptops are very slow */
#else
#define WAIT_READY      (HZ/10)         /* 100msec - should be instantaneous */
#endif /* CONFIG_APM || CONFIG_APM_MODULE */

<--  snip  -->

On the one hand APM isn't enabled on all laptops.
On the other hand, this also affects regular PCs with APM support (or 
using a distribution kernel with APM support).

The time for the !APM case was already increased from 30msec in 2.4 .
Isn't there a timeout that is suitable for all cases?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


             reply	other threads:[~2004-12-09  3:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-09  3:44 Adrian Bunk [this message]
2004-12-09 10:53 ` IDE: strange WAIT_READY dependency on APM Pavel Machek
2004-12-10 15:20 ` Alan Cox
2004-12-11 17:30   ` [2.6 patch] IDE: remove " Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041209034438.GF22324@stusta.de \
    --to=bunk@stusta.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox