From: John Levon <levon@movementarian.org>
To: Akinobu Mita <amgta@yacht.ocn.ne.jp>
Cc: Greg Banks <gnb@sgi.com>, Philippe Elie <phil.el@wanadoo.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [mm patch] oprofile: backtrace operation does not initialized
Date: Thu, 9 Dec 2004 14:55:19 +0000 [thread overview]
Message-ID: <20041209145519.GA78695@compsoc.man.ac.uk> (raw)
In-Reply-To: <200412092353.53634.amgta@yacht.ocn.ne.jp>
On Thu, Dec 09, 2004 at 11:53:53PM +0900, Akinobu Mita wrote:
> Or, It may be better to revert the return type of oprofile_arch_init()
> from "void" to "int" to get the result of initialization.
> Though I don't know when/why its interface was changed. and some
> architectures (ppc, sh64, m32r) remain to have old interfaces in -mm.
I've also lost track of why we don't return -ENODEV from the
arch_init().
We should set -ENODEV after setting ->backtrace as appropriate. Then the
code should do what it used to do:
138 int err = oprofile_arch_init(&oprofile_ops);
139
140 if (err == -ENODEV || timer) {
141 timer_init(&oprofile_ops);
142 err = 0;
143 } else if (err) {
144 goto out;
145 }
john
next prev parent reply other threads:[~2004-12-09 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-08 9:30 [mm patch] oprofile: backtrace operation does not initialized Akinobu Mita
2004-12-08 9:34 ` Akinobu Mita
2004-12-08 11:13 ` Ingo Molnar
2004-12-08 11:37 ` Akinobu Mita
2004-12-08 16:00 ` John Levon
2004-12-08 22:31 ` Greg Banks
2004-12-08 23:56 ` Philippe Elie
2004-12-09 0:39 ` Greg Banks
2004-12-09 1:46 ` John Levon
2004-12-09 1:50 ` Greg Banks
2004-12-09 2:23 ` John Levon
2004-12-09 14:22 ` Akinobu Mita
2004-12-09 14:53 ` Akinobu Mita
2004-12-09 14:55 ` John Levon [this message]
2004-12-09 15:27 ` Greg Banks
2004-12-09 15:23 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041209145519.GA78695@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=amgta@yacht.ocn.ne.jp \
--cc=gnb@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.el@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox