From: Ingo Oeser <ioe@axxeo.de>
To: dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH 4/5] NOMMU: Make POSIX shmem work on ramfs-backed files
Date: Fri, 10 Dec 2004 04:08:33 +0100 [thread overview]
Message-ID: <200412100408.33482.ioe@axxeo.de> (raw)
In-Reply-To: <200412091508.iB9F8wja027564@warthog.cambridge.redhat.com>
You wrote:
> diff -uNrp linux-2.6.10-rc2-mm3-mmcleanup/fs/ramfs/Makefile
> linux-2.6.10-rc2-mm3-shmem/fs/ramfs/Makefile ---
> linux-2.6.10-rc2-mm3-mmcleanup/fs/ramfs/Makefile 2004-06-18
> 13:41:28.000000000 +0100 +++
> linux-2.6.10-rc2-mm3-shmem/fs/ramfs/Makefile 2004-11-26 15:36:07.000000000
> +0000 @@ -4,4 +4,10 @@
>
> obj-$(CONFIG_RAMFS) += ramfs.o
>
> -ramfs-objs := inode.o
> +ifeq ($(CONFIG_MMU),y)
> +ramfs-objs := file-mmu.o
> +else
> +ramfs-objs := file-nommu.o
> +endif
> +
> +ramfs-objs += inode.o
What about this pattern instead:
file-mmu-y := file-mmu.o
file-mmu-n := file-nommu.o
file-mmu- := file-nommu.o
ramfs-objs += file-mmu-$(CONFIG_MMU)
Requires more work while writing it, but removes the ifeq,
which should be avoided in makefiles as hell
--
Ingo Oeser
axxeo GmbH
Tiestestr. 16, 30171 Hannover
Tel. +49-511-4753706
Fax. +49-511-4753716
mailto:support@axxeo.de
next prev parent reply other threads:[~2004-12-10 3:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-09 15:08 [PATCH 1/5] NOMMU: MM cleanups dhowells
2004-12-09 15:08 ` [PATCH 2/5] NOMMU: High-order page management overhaul dhowells
2004-12-09 15:08 ` [PATCH 4/5] NOMMU: Make POSIX shmem work on ramfs-backed files dhowells
2004-12-10 3:08 ` Ingo Oeser [this message]
2004-12-10 14:28 ` David Howells
2004-12-10 17:23 ` Ingo Oeser
2004-12-09 15:08 ` [PATCH 5/5] NOMMU: Futher nommu shared memory support dhowells
2004-12-09 15:08 ` [PATCH 3/5] NOMMU: mmap fixes and extensions dhowells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412100408.33482.ioe@axxeo.de \
--to=ioe@axxeo.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox