Re: [PATCH 4/5] NOMMU: Make POSIX shmem work on ramfs-backed files

David Howells
2004-12-10T14:28:07Z

Ingo Oeser <ioe@axxeo.de> wrote:

> What about this pattern instead:
>
> file-mmu-y := file-mmu.o
> file-mmu-n := file-nommu.o
> file-mmu- := file-nommu.o
> ramfs-objs += file-mmu-$(CONFIG_MMU)
>
> Requires more work while writing it, but removes the ifeq,
> which should be avoided in makefiles as hell

Your suggestion adds duplicate information. This solution is worse than the
thing you're trying to fix.

Do we really need both the file-mmu-n and file-mmu- variants?

Actually, this would probably do instead:

file-mmu-y := file-nommu.o
file-mmu-$(CONFIG_MMU) := file-mmu.o
ramfs-objs := inode.o file-mmu-y

Will this work? Or should it be $(file-mmu-y) on the last line?

David