public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] debugfs - yet another in-kernel file system
Date: Thu, 9 Dec 2004 23:54:29 -0800	[thread overview]
Message-ID: <20041210075429.GA30223@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.53.0412100805440.8273@yvahk01.tjqt.qr>

On Fri, Dec 10, 2004 at 08:07:20AM +0100, Jan Engelhardt wrote:
> >What if there was a in-kernel filesystem that was explicitly just for
> >putting debugging stuff?  Some place other than proc and sysfs, and that
> >was easier than both of them to use.  Yet it needed to also be able to
> >handle complex stuff like seq file and raw file_ops if needed.
> 
> As for modules, they could just wrap a variable in a module_param, don't they?

For input stuff, yes.  And for simple types that are not debug stuff,
yes, that is the proper place for them.

> I have to admit that adding another filesystem that is very like procfs or
> sysfs make some kind of redundancy.

Why?  The main issue is the discussion usually goes like this:

Me:  Hey, the /proc/driver/foo/foo_value really shouldn't be in proc.
Developer:  Ok, but it has a lot of really good debug stuff in it.  Can
I put it in sysfs?
Me:  No, sysfs is for one-value-per-file whenever possible.  It needs to
go somewhere else.
Developer:  Well, if you don't have anywhere else to put it, why are you
even bringing this up at all.  Go away and leave me alone.


Now we have a place to put this stuff.  If you look through the way
drivers use /proc these days, there is still a lot of stuff that needs
to get moved out, that can go in debugfs.

As for "another filesystem", it's tiny due to using libfs, and it will
compile away into nothing if not selected (so in the end, provides the
ability to make the final kernel image smaller.)

thanks,

greg k-h

  reply	other threads:[~2004-12-10  7:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-10  0:50 [RFC PATCH] debugfs - yet another in-kernel file system Greg KH
2004-12-10  0:55 ` [RFC PATCH] convert uhci-hcd to use debugfs Greg KH
2004-12-10 14:15   ` Josh Boyer
2004-12-10 15:27     ` Greg KH
2004-12-10 16:21       ` Josh Boyer
2004-12-10 17:17         ` Comments on new kernel dev. model Peter Karlsson
2004-12-10 23:44           ` Greg KH
2004-12-10  7:07 ` [RFC PATCH] debugfs - yet another in-kernel file system Jan Engelhardt
2004-12-10  7:54   ` Greg KH [this message]
2004-12-10  8:00     ` Jan Engelhardt
2004-12-10 16:02       ` Greg KH
2004-12-10 14:46 ` Josh Boyer
2004-12-10 15:30   ` Greg KH
2004-12-10 16:26     ` Josh Boyer
2004-12-10 17:21 ` Jörn Engel
2004-12-10 17:35   ` Greg KH
2004-12-10 18:29     ` Jörn Engel
2004-12-10 19:38 ` Roland Dreier
2004-12-11  1:29 ` [linux-usb-devel] " David Brownell
2004-12-11  1:39   ` Greg KH
2004-12-11  2:02     ` David Brownell
2004-12-11  2:05       ` Greg KH
2004-12-11  2:26     ` Roland Dreier
2004-12-11  2:32       ` Greg KH
2004-12-11 13:23         ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041210075429.GA30223@kroah.com \
    --to=greg@kroah.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox