From: Dave Jones <davej@redhat.com>
To: Miguel Angel Flores <maf@sombragris.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aic7xxx driver warning
Date: Fri, 10 Dec 2004 17:24:55 -0500 [thread overview]
Message-ID: <20041210222455.GE6648@redhat.com> (raw)
In-Reply-To: <41BA201C.9090103@sombragris.com>
On Fri, Dec 10, 2004 at 11:15:56PM +0100, Miguel Angel Flores wrote:
> Hi all,
>
> These are two possible patches for the 2.6.10rc3. The patches correct a
> compiler warning when CONFIG_HIGHMEM64G is not defined.
>
> Both patches works well. "Opt1" is the Alan Cox way and "Opt2" is the
> MaF way :-)
- mask_39bit = 0x7FFFFFFFFFULL;
if (sizeof(dma_addr_t) > 4
&& ahc_linux_get_memsize() > 0x80000000
&& pci_set_dma_mask(pdev, mask_39bit) == 0) {
+ mask_39bit = (dma_addr_t)0x7FFFFFFFFFULL;
ahc->flags |= AHC_39BIT_ADDRESSING;
ahc->platform_data->hw_dma_mask = mask_39bit;
} else {
How can this work ? You're using mask_39bit before you set it
(See the pci_set_dma_mask call)
Dave
prev parent reply other threads:[~2004-12-10 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-10 22:15 [PATCH] aic7xxx driver warning Miguel Angel Flores
2004-12-10 22:24 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041210222455.GE6648@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maf@sombragris.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox