From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261974AbULKRW4 (ORCPT ); Sat, 11 Dec 2004 12:22:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261972AbULKRW4 (ORCPT ); Sat, 11 Dec 2004 12:22:56 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:11964 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S261971AbULKRWx (ORCPT ); Sat, 11 Dec 2004 12:22:53 -0500 Date: Sat, 11 Dec 2004 18:22:03 +0100 From: Jens Axboe To: James Bottomley Cc: "Randy.Dunlap" , Andrew Morton , Linus Torvalds , SCSI Mailing List , Linux Kernel Subject: Re: [BK PATCH] SCSI -rc fixes for 2.6.10-rc3 Message-ID: <20041211172202.GD3033@suse.de> References: <1102650988.3814.13.camel@mulgrave> <20041210201115.GD12581@suse.de> <41BA2948.4030906@osdl.org> <1102776407.5688.4.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1102776407.5688.4.camel@mulgrave> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 11 2004, James Bottomley wrote: > On Fri, 2004-12-10 at 14:55 -0800, Randy.Dunlap wrote: > > I have a drive, but I'm not near a highmem machine atm. > > I can test it next week if no one else does so. > > So would you be amenable to fixing it properly? It looks like what > needs to happen is that it needs to accept its commands into the > scsi_pointer with page and offset (scsi_pointer doesn't have these > fields, but you could probably cast in ptr and dma_handle). Then do a > kmap/kunmap around imm_in() and imm_out() when it's operating on > SCp.ptr. Yep, that would be the optimal. But still, given the hardware, I feel the hacky workaround would be acceptable. If Randy wants to fix it properly being able to test it, perfect. -- Jens Axboe