public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: John Mock <kd6pag@qsl.net>, Andrew Morton <akpm@osdl.org>,
	zadiglist@zadig.ca,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Pavel Machek <pavel@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3
Date: Mon, 13 Dec 2004 10:13:17 +0000	[thread overview]
Message-ID: <20041213101316.A19461@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20041202144836.A7760@flint.arm.linux.org.uk>; from rmk+lkml@arm.linux.org.uk on Thu, Dec 02, 2004 at 02:48:36PM +0000

On Thu, Dec 02, 2004 at 02:48:36PM +0000, Russell King wrote:
> On Thu, Dec 02, 2004 at 12:51:22AM -0800, John Mock wrote:
> > A second crash involving software suspend looks
> > like it might be 'UART' related, but i'm not sure if i can reproduce that
> > one easily (as i'm not running that kernel).
> 
> Please try this patch.

John - Is there any progress on this?

> --- linux-2.6-serial/drivers/serial/serial_core.c	Wed Dec  1 10:41:10 2004
> +++ linux/drivers/serial/serial_core.c	Thu Dec  2 13:34:47 2004
> @@ -1877,7 +1877,21 @@
>  	 * Re-enable the console device after suspending.
>  	 */
>  	if (uart_console(port)) {
> -		uart_change_speed(state, NULL);
> +		struct termios termios;
> +
> +		/*
> +		 * First try to use the console cflag setting.
> +		 */
> +		memset(&termios, 0, sizeof(struct termios));
> +		termios.c_cflag = port->cons->cflag;
> +
> +		/*
> +		 * If that's unset, use the tty termios setting.
> +		 */
> +		if (state->info && state->info->tty && termios.c_cflag == 0)
> +			termios = *state->info->tty->termios;
> +
> +		port->ops->set_termios(port, &termios, NULL);
>  		console_start(port->cons);
>  	}
>  
> 
> 
> -- 
> Russell King
>  Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
>  maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
>                  2.6 Serial core
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  reply	other threads:[~2004-12-13 10:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-02  8:51 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3 John Mock
2004-12-02 10:25 ` Pavel Machek
2004-12-02 14:48 ` Russell King
2004-12-13 10:13   ` Russell King [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-12-02 19:24 Tovar
2004-12-02 17:49 John Mock
2004-12-02 19:10 ` Andrew Morton
2004-11-20 16:58 John Mock
2004-11-20 18:51 ` Pavel Machek
2004-11-20 19:11   ` Lee Revell
2004-11-22 11:58     ` Takashi Iwai
2004-11-30  0:35   ` Andrew Morton
2004-11-30 10:22     ` Pavel Machek
2004-11-19  1:05 John Mock
2004-11-19  2:26 ` Benjamin Herrenschmidt
2004-11-18 22:49 John Mock
2004-11-18 23:17 ` Benjamin Herrenschmidt
2004-11-19 11:49 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041213101316.A19461@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=kd6pag@qsl.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=zadiglist@zadig.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox