public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Nathan Scott <nathans@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] some XFS cleanups (fwd)
Date: Tue, 14 Dec 2004 01:06:21 +0100	[thread overview]
Message-ID: <20041214000621.GO23151@stusta.de> (raw)
In-Reply-To: <20041208050348.GI1611@frodo>

On Wed, Dec 08, 2004 at 04:03:48PM +1100, Nathan Scott wrote:
>...
> > The patch below makes the following cleanups in the XFS code:
> > - remove the unused global function vfs_dmapiops
> > - remove some unused #define's
> 
> These first changes aren't really useful; they make the DMAPI
> code more difficult to integrate and manage in our trees, for
> not-enough gain.
>...

OK, then the #define's have to stay.

Would it be OK to make vfs_dmapiops #ifdef on the DMAPI code?

> Nathan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2004-12-14  0:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-07 19:35 [2.6 patch] some XFS cleanups (fwd) Adrian Bunk
2004-12-08  5:03 ` Nathan Scott
2004-12-14  0:06   ` Adrian Bunk [this message]
2004-12-14  0:36     ` Nathan Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041214000621.GO23151@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=nathans@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox