From: Andi Kleen <ak@suse.de>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
ak@suse.de
Subject: Re: [PATCH] 2.6.10-rc2-mm4 panic on AMD64
Date: Tue, 14 Dec 2004 09:07:08 +0100 [thread overview]
Message-ID: <20041214080708.GP1046@wotan.suse.de> (raw)
In-Reply-To: <1102380640.2826.13.camel@dyn318077bld.beaverton.ibm.com>
Sorry for the late answer, I was travelling.
On Mon, Dec 06, 2004 at 04:50:40PM -0800, Badari Pulavarty wrote:
> Ok !! Here is the patch to fix the problem. It works
> fine on my 4-way AMD64 box.
>
> Rafael, can you verify on yours ?
>
> Problem is with "c - cpu_data" arthimetic. "c" could
> be "boot_cpu_data" or "cpu_data".
>
> Andi, is this reasonable ?
Yes thanks. Looks good (except for the whitespace in the if ;)
Andrew, I assume you already merged it and pushed it to Linus.
-Andi (wearing a brown paper bag)
[...]
> --- linux.org/arch/x86_64/kernel/setup.c 2004-12-06 17:47:46.000000000 -0800
> +++ linux/arch/x86_64/kernel/setup.c 2004-12-06 17:43:39.000000000 -0800
> @@ -947,7 +947,8 @@ void __init identify_cpu(struct cpuinfo_
> mcheck_init(c);
> #endif
> #ifdef CONFIG_NUMA
> - numa_add_cpu(c - cpu_data);
> + if ( c != &boot_cpu_data )
> + numa_add_cpu(c - cpu_data);
> #endif
> }
>
prev parent reply other threads:[~2004-12-14 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 21:40 2.6.10-rc2-mm4 panic on AMD64 Badari Pulavarty
2004-12-06 22:15 ` Andrew Morton
2004-12-06 23:22 ` Rafael J. Wysocki
2004-12-07 0:50 ` [PATCH] " Badari Pulavarty
2004-12-07 21:14 ` Rafael J. Wysocki
2004-12-14 8:07 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041214080708.GP1046@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox