public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
	Dave Airlie <airlied@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at mm/rmap.c:480 in 2.6.10-rc3-bk7
Date: Thu, 16 Dec 2004 15:28:20 +0100	[thread overview]
Message-ID: <20041216142820.GN28286@dualathlon.random> (raw)
In-Reply-To: <Pine.LNX.4.44.0412160455520.4496-100000@localhost.localdomain>

On Thu, Dec 16, 2004 at 05:18:59AM +0000, Hugh Dickins wrote:
> going on, such avoidance may be the right course of action; but not yet.

Yes, the real reason of my changes are quite unrelated to this bug: i.e.
we to keep mapcount zero for all pages with page->mapping = NULL so they
don't even enter objrmap.c, and to enforce other nice bits like that
page-reserved must have page->mapping = NULL and other VM_RESERVED
related enforcements. It wasn't meant to hide bugs and infact we should
remove anything that that hides real bugs if my changes are truly hiding
them. I still don't excude they're a real fix though, the fact I can't
tell the exact reason why they help doesn't mean they're not fixing the
real bug (there's quite some code in objrmap.c that definitely should
not be involved with non-pageable pages, and my patch enforces this,
unlike mainline).

Infact if a page becomes suddenly unreserved, shouldn't the accounting
break anyways at the page->count level? The page would be freed twice
instead of once.

I wonder if the sg_cleanup explains why some mapped reserved page
suddenly become unreserved. Can you track if the DRM_IOCTL_SG_FREE is
being called in a mapped vma? I guess you could start by enabling
DRM(flags) in drm_init.h.

#if 0
int DRM(flags) = DRM_FLAG_DEBUG;
#else
int DRM(flags) = 0;
#endif

(set to 1 and then it should print something)

  reply	other threads:[~2004-12-16 14:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 16:45 kernel BUG at mm/rmap.c:480 in 2.6.10-rc3-bk7 Greg KH
2004-12-14 23:26 ` Hugh Dickins
2004-12-15  0:10   ` Nick Piggin
2004-12-15  0:19   ` Greg KH
2004-12-15  1:11     ` Greg KH
2004-12-15 17:23       ` Hugh Dickins
2004-12-15 17:58         ` Greg KH
2004-12-15 18:48           ` Hugh Dickins
2004-12-15 22:22             ` Hugh Dickins
2004-12-15 22:33             ` Dave Airlie
2004-12-15 23:19               ` Greg KH
2004-12-15 19:03           ` Andrea Arcangeli
2004-12-15 22:48             ` Andrea Arcangeli
2004-12-15 23:41               ` Greg KH
2004-12-16  5:18                 ` Hugh Dickins
2004-12-16 14:28                   ` Andrea Arcangeli [this message]
2004-12-16 17:03                     ` Hugh Dickins
2004-12-15  0:43   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041216142820.GN28286@dualathlon.random \
    --to=andrea@suse.de \
    --cc=airlied@gmail.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox