Re: [patch] [RFC] move 'struct page' into its own header

Dave Hansen
2004-12-16T22:51:24Z

On Thu, 2004-12-16 at 14:25, Christoph Hellwig wrote:
> On Thu, Dec 16, 2004 at 02:04:15PM -0800, Dave Hansen wrote:
> > So, put 'struct page' into structpage.h, along with a nasty comment
> > telling everyone to keep their grubby mitts out of the file.

> What about calling it page.h? structfoo.h sounds like a really strange
> name.

The only reason I didn't do that is that there is already an
asm/page.h. But, linux/page.h would be a fine name, too.

> And while you're at it page-flags.h should probably be merged into
> it.

The only tricky part might be page-flags.h includes asm/pgtable.h, which
(on i386) includes linux/slab.h, which includes asm/page.h. This might
somewhat restrict the number of places that the new header can be
included. As it stands, it can be included (and get you a full
definition of struct page) almost anywhere.

But, I'm not quite sure why page-flags.h even needs asm/pgtable.h. I
just took it out in i386, and it still compiles just fine. Maybe it is
needed for another architecture.

-- Dave