From: Jens Axboe <axboe@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Rashkae <rashkae@tigershaunt.com>, linux-kernel@vger.kernel.org
Subject: Re: Cannot mount multi-session DVD with ide-cd, must use ide-scsi
Date: Fri, 17 Dec 2004 13:08:54 +0100 [thread overview]
Message-ID: <20041217120854.GC3140@suse.de> (raw)
In-Reply-To: <20041217001315.1b31cf2d.akpm@osdl.org>
On Fri, Dec 17 2004, Andrew Morton wrote:
> Rashkae <rashkae@tigershaunt.com> wrote:
> >
> > I can confirm that Linux Kerenl 2.6.9 still cannot mount a
> > multi-session DVD if the last session starts at > 2.2 GB. The
> > only information on this problem I can find is here:
> >
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=108827602322464&w=2
> >
> > Is there a patch anywhere to address this?
>
> Please test this. Jens, could you please check this one?
It looks fine for the case where the tocentry read suceeds, but you
should change the fallback assignment to be lba based as well I think.
> diff -puN drivers/ide/ide-cd.c~ide-cd-unable-to-read-multisession-dvds drivers/ide/ide-cd.c
> --- 25/drivers/ide/ide-cd.c~ide-cd-unable-to-read-multisession-dvds 2004-12-11 22:14:16.629388296 -0800
> +++ 25-akpm/drivers/ide/ide-cd.c 2004-12-11 22:14:16.635387384 -0800
> @@ -2353,7 +2353,7 @@ static int cdrom_read_toc(ide_drive_t *d
> /* Read the multisession information. */
> if (toc->hdr.first_track != CDROM_LEADOUT) {
> /* Read the multisession information. */
> - stat = cdrom_read_tocentry(drive, 0, 1, 1, (char *)&ms_tmp,
> + stat = cdrom_read_tocentry(drive, 0, 0, 1, (char *)&ms_tmp,
> sizeof(ms_tmp), sense);
> if (stat) return stat;
> } else {
it's the bottom part of that else.
--
Jens Axboe
next prev parent reply other threads:[~2004-12-17 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-17 1:20 Cannot mount multi-session DVD with ide-cd, must use ide-scsi Rashkae
2004-12-17 8:13 ` Andrew Morton
2004-12-17 12:08 ` Jens Axboe [this message]
2004-12-17 18:33 ` Kronos
2004-12-17 18:57 ` Doug Maxey
2004-12-17 19:28 ` Jens Axboe
2004-12-17 20:53 ` Doug Maxey
2004-12-17 19:27 ` Jens Axboe
2004-12-18 17:10 ` Rashkae
2004-12-18 17:36 ` Randy.Dunlap
2004-12-18 20:20 ` Rashkae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041217120854.GC3140@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashkae@tigershaunt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox